Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: settings to limit your fast-forward game speed #8766

Merged
merged 1 commit into from Feb 28, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Feb 28, 2021

Motivation / Problem

Fast forward is now so crazy fast, that it is not really useful anymore to anyone. So, instead, set a default upper-limit to how fast it is.

This is fully configurable in the settings what you want the fast-forward speed to be, including the old "infinite speed".

Ideally, we want a GUI in addition to the setting, which #8693 is about, but to make sure we can already limit the fast-forward speed, a separate PR to make that part happen.

Description

By default this setting is set to 2500% normal game speed.

image

Limitations

  • People might initially be confused why their Fast-Forward become so much slower.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@James103
Copy link
Contributor

Alternative to #8693

@TrueBrain
Copy link
Member Author

TrueBrain commented Feb 28, 2021

Alternative to #8693

No, not an alternative. Work to prepare for #8693. #8693 adds a GUI to control the game-speed, where this PR only makes it into a setting.

@nielsmh
Copy link
Contributor

nielsmh commented Feb 28, 2021

I'd suggest formatting the setting as Fast forward speed limit: 16x normal game speed
Phrasing it with "speed limit" or similar makes it more clear that it may not be possible to hit in all circumstances.
Showing it as multiplier is probably easier to read than percent.

I think a default of 25x or even 50x will be better.

@TrueBrain
Copy link
Member Author

Showing it as multiplier is probably easier to read than percent.

Except that that doesn't work for values < 100, which work just fine too :D

@nielsmh
Copy link
Contributor

nielsmh commented Feb 28, 2021

Showing it as multiplier is probably easier to read than percent.

Except that that doesn't work for values < 100, which work just fine too :D

You can turn the fast forward button into a slow forward button?

@TrueBrain
Copy link
Member Author

Showing it as multiplier is probably easier to read than percent.

Except that that doesn't work for values < 100, which work just fine too :D

You can turn the fast forward button into a slow forward button?

Yes sir! I was even considering flipping the button in the toolbar in that case, but .. yeah :P

@TrueBrain TrueBrain changed the title Add: settings to change your fast-forward game speed Add: settings to limityour fast-forward game speed Feb 28, 2021
@TrueBrain TrueBrain changed the title Add: settings to limityour fast-forward game speed Add: settings to limit your fast-forward game speed Feb 28, 2021
@LordAro
Copy link
Member

LordAro commented Feb 28, 2021

I would go with "and can vary depending on the game"

src/video/allegro_v.cpp Outdated Show resolved Hide resolved
By default this setting is set to 2500% normal game speed.
@LordAro LordAro merged commit c3dc27e into OpenTTD:master Feb 28, 2021
@TrueBrain TrueBrain deleted the ff-setting branch October 31, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants