Add: Allow translation of "(Directory)" and "(Parent directory)" #8639

glx22 · 2021-02-02T17:35:57Z

Closes #8636

Motivation / Problem

As reported in #8636, (Directory) and (Parent directory) in file lists are untranslatable.

I made them translatable.

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

The bug fix is important enough to be backported? (label: 'backport requested')
This PR affects the save game format? (label 'savegame upgrade')
This PR affects the GS/AI API? (label 'needs review: Script API')
- ai_changelog.hpp, gs_changelog.hpp need updating.
- The compatibility wrappers (compat_*.nut) need updating.
This PR affects the NewGRF API? (label 'needs review: NewGRF')
- newgrf_debug_data.h may need updating.
- PR must be added to API tracker

src/lang/english.txt

Wuzzy2 · 2021-02-08T18:21:05Z

I agree that ".." should not be localized at all. The ".." is a special directory name on Linux and doesn't change per-language.

glx22 force-pushed the translatable_file_list branch from d1911f1 to b71809a Compare February 2, 2021 17:53

LordAro previously approved these changes Feb 7, 2021

View reviewed changes

glx22 dismissed LordAro’s stale review via f9af9c9 February 7, 2021 15:40

glx22 force-pushed the translatable_file_list branch from b71809a to f9af9c9 Compare February 7, 2021 15:40

Eilon reviewed Feb 8, 2021

View reviewed changes

src/lang/english.txt Outdated Show resolved Hide resolved

michicc previously approved these changes Feb 14, 2021

View reviewed changes

Add: Allow translation of "(Directory)" and "(Parent directory)"

c9383f8

glx22 dismissed michicc’s stale review via c9383f8 February 14, 2021 22:56

glx22 force-pushed the translatable_file_list branch from f9af9c9 to c9383f8 Compare February 14, 2021 22:56

michicc approved these changes Feb 14, 2021

View reviewed changes

glx22 merged commit 45e8b7a into OpenTTD:master Feb 14, 2021

glx22 deleted the translatable_file_list branch February 14, 2021 23:08