[WPT/content-security-policy] Add generated tests #27535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 8, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2681956
branch
4 times, most recently
from
8bc9d65
to
bf6602a
Compare
This CL adds generated CSP tests using /wpt/common/security-features/tools/generate.py under /wpt/content-security-policy/gen/, primarily to add comprehensive test coverage around workers. This CL only adds tests for - worker-src and script-src directives - worker- and script-related subresource requests - on top-level Documents. This CL doesn't remove manually-written tests with similar test coverage, because it would still need careful comparison of test coverage and adding more test assertions in /wpt/content-security-policy/generic/test-case.sub.js. The failures on Chromium are about the lack of securitypolicyviolation events due to https://crbug.com/928964. The failures on other browsers are, as far as I briefly looked at, about the lack of securitypolicyviolation events, or due to unimplemented support for underlying features like (module) SharedWorkers. Bug: 928964, 1179832 Change-Id: Ib1b81827ab2547a6c59071b2f1a6613c9f9a32e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2681956 Reviewed-by: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#857969}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2681956
branch
from
bf6602a
to
e76abf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds generated CSP tests using
/wpt/common/security-features/tools/generate.py
under
/wpt/content-security-policy/gen/,
primarily to add comprehensive test coverage around workers.
This CL only adds tests for
This CL doesn't remove manually-written tests
with similar test coverage, because it would still need
careful comparison of test coverage and
adding more test assertions in
/wpt/content-security-policy/generic/test-case.sub.js.
The failures on Chromium are about the lack of
securitypolicyviolation events due to https://crbug.com/928964.
The failures on other browsers are, as far as I briefly looked at,
about the lack of securitypolicyviolation events, or
due to unimplemented support for underlying features
like (module) SharedWorkers.
Bug: 928964, 1179832
Change-Id: Ib1b81827ab2547a6c59071b2f1a6613c9f9a32e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2681956
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857969}