Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 45dda96dd625
Choose a base ref
...
head repository: NixOS/nix
compare: ce796cbc2860
Choose a head ref
  • 12 commits
  • 18 files changed
  • 1 contributor

Commits on Feb 5, 2021

  1. Only commit to the cache at the end of the evaluation 

    Make the evaluation with a cold cache muuuuch faster (nearly 3x faster
in my benchmarks)
    @thufschmitt
    thufschmitt committed Feb 5, 2021
    Copy the full SHA
    ea87cd5 View commit details
    Browse the repository at this point in the history

  2. Make NIX_SHOW_STATS work with new-style commands

    @thufschmitt
    thufschmitt committed Feb 5, 2021
    Copy the full SHA
    808af0e View commit details
    Browse the repository at this point in the history

  3. Add some stats for the evaluation caching

    @thufschmitt
    thufschmitt committed Feb 5, 2021
    Copy the full SHA
    0981323 View commit details
    Browse the repository at this point in the history

  4. eval-cache -> cached-eval 

    To let place to a proper eval-cache module that would just do the
caching
    @thufschmitt
    thufschmitt committed Feb 5, 2021
    Copy the full SHA
    4eddb2c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. WIP: Add a new lower-level eval cache

    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    b63b0fa View commit details
    Browse the repository at this point in the history

  2. Make the new eval cache work

    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    10e88e6 View commit details
    Browse the repository at this point in the history

  3. fixup! Make the new eval cache work

    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    8a98632 View commit details
    Browse the repository at this point in the history

  4. fixup! Make the new eval cache work

    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    908aec7 View commit details
    Browse the repository at this point in the history

  5. Use raw pointers for the eval cache 

    This causes a nice speedup improvement.

It's likely that Boehm doesn't gc these properly, but in that case that
was already the case with the shared_pointers that were used previously,
so…
    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    3f5deca View commit details
    Browse the repository at this point in the history

  6. Add a more thoughrough reporting of the caching 

    - Add more debug infos for hits/misses
- Fill some stat reports to have an idea how effective it is
    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    9a0063f View commit details
    Browse the repository at this point in the history

  7. Cleanup the cached values types

    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    8da755d View commit details
    Browse the repository at this point in the history

  8. Also cache int and float values

    @thufschmitt
    thufschmitt committed Feb 8, 2021
    Copy the full SHA
    ce796cb View commit details
    Browse the repository at this point in the history