Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applet.interface.analyzer - pullups look like they have been swapped in applet python #271

Closed
TomKeddie opened this issue Feb 8, 2021 · 1 comment
Closed

applet.interface.analyzer - pullups look like they have been swapped in applet python #271

TomKeddie opened this issue Feb 8, 2021 · 1 comment
Labels
applet Component: applet

Comments

@TomKeddie
Copy link
Contributor

TomKeddie commented Feb 8, 2021 •
edited

ref https://github.com/GlasgowEmbedded/glasgow/blob/master/software/glasgow/applet/interface/analyzer/__init__.py#L85

If this is correct I suggest comment to explain what's going on.

        if args.pull_ups:
            pull_low = set(args.pin_set_i)
        if args.pull_downs:
            pull_high = set(args.pin_set_i)
@whitequark
Copy link
Member

That's a typo I believe. Would you be willing to send a PR?

@whitequark whitequark added the applet Component: applet label Feb 9, 2021
TomKeddie pushed a commit to TomKeddie/glasgow that referenced this issue Feb 9, 2021
applet.interface.analyzer: fix pullup/pulldown polarity
9c40cf2 
GlasgowEmbedded#271
@TomKeddie TomKeddie mentioned this issue Feb 9, 2021
Merged
whitequark pushed a commit that referenced this issue Feb 9, 2021
@whitequark
applet.interface.analyzer: fix pullup/pulldown polarity
25fe8d3 
#271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
applet Component: applet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @TomKeddie