Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/azure-agent: fix deprecation warning #109099

Merged
merged 1 commit into from Jan 16, 2021
Merged

nixos/azure-agent: fix deprecation warning #109099

merged 1 commit into from Jan 16, 2021

Conversation

jpotier
Copy link
Contributor

@jpotier jpotier commented Jan 12, 2021

Motivation for this change

Resolve deprecation warning:

trace: warning: The option `services.logrotate.config' defined in `/var/src/nixpkgs/nixos/modules/virtualisation/azure-agent.nix' has been renamed to `services.logrotate.extraConfig'.

while building a NixOS Azure Image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

It's there any ability to log to journald instead? That is the preferred way with NixOS.

@jpotier
Copy link
Contributor Author

jpotier commented Jan 12, 2021

I'm sorry, I only have limited understanding of how the azure-agent actually works. I just know it's a complicated python application. I would consider the update to be necessary, but I don't enough time to dig into it. So, I did the next best thing: make sure it won't break with the next major release of nixos.

@SuperSandro2000
Copy link
Member

@jonringer can you help here?

jonringer
jonringer approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@aanderse aanderse merged commit 6b0ba74 into NixOS:master Jan 16, 2021
@jpotier jpotier deleted the fix-deprecation-warning-azure-agent branch January 17, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpotier @aanderse @SuperSandro2000 @jonringer @MartinPotier