Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new VSCode extensions #109120

Merged
merged 8 commits into from Jan 14, 2021
Merged

Adding new VSCode extensions #109120

merged 8 commits into from Jan 14, 2021

Conversation

superherointj
Copy link
Contributor

  • It respects alphabetical order so data can be normalized.

List of changes:
CoenraadS.bracket-pair-colorizer: init at 1.0.61
donjayamanne.githistory: init at 0.6.14
esbenp.prettier-vscode: init at 5.8.0
file-icons.file-icons: init at 1.0.28
freebroccolo.reasonml: init at 1.0.38
jnoortheen.nix-ide: updated metadata
ocamllabs.ocaml-platform: init at 1.5.1

@hugolgst
Copy link
Member

Result of nixpkgs-review pr 109120 1

6 packages built:
  • vscode-extensions.CoenraadS.bracket-pair-colorizer
  • vscode-extensions.donjayamanne.githistory
  • vscode-extensions.esbenp.prettier-vscode
  • vscode-extensions.file-icons.file-icons
  • vscode-extensions.freebroccolo.reasonml
  • vscode-extensions.ocamllabs.ocaml-platform

pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
@superherointj
Copy link
Contributor Author

superherointj commented Jan 12, 2021

For a new PR (which is ready), I have normalized "pkgs/misc/vscode-extensions/default.nix". Refactored to respect alphabetical order, standardized meta-data, filled meta-data for currently available extensions. Removed stdenv.lib. I need this PR to be approved before I can push the new PR so I do not mix new extensions and global refactoring. Would appreciate if anyone can merge this. Thanks.

@SuperSandro2000
Copy link
Member

@superherointj can you please fix the merge conflict?

@superherointj
Copy link
Contributor Author

Is it fine now or do I have to change order or do something else?

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/109120

6 packages built:
vscode-extensions.CoenraadS.bracket-pair-colorizer vscode-extensions.donjayamanne.githistory vscode-extensions.esbenp.prettier-vscode vscode-extensions.file-icons.file-icons vscode-extensions.freebroccolo.reasonml vscode-extensions.ocamllabs.ocaml-platform

thanks @SuperSandro2000

@jonringer jonringer merged commit ec26812 into NixOS:master Jan 14, 2021
@superherointj superherointj deleted the vscode-extensions-by-superherointj branch January 14, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants