Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyfido: init at 2.1.1 #109234

Merged
merged 2 commits into from Jan 13, 2021
Merged

python3Packages.pyfido: init at 2.1.1 #109234

merged 2 commits into from Jan 13, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 12, 2021

Motivation for this change

Python client to get your consumption data from your fido account (www.fido.ca).

https://github.com/titilambert/pyfido

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/109234

3 packages built:
python37Packages.pyfido python38Packages.pyfido python39Packages.pyfido

@jonringer jonringer merged commit a317a15 into NixOS:master Jan 13, 2021
@fabaff fabaff deleted the pyfido branch January 13, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants