Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findutils: 4.7.0 -> 4.8.0 #109058

Merged
merged 1 commit into from Jan 22, 2021
Merged

findutils: 4.7.0 -> 4.8.0 #109058

merged 1 commit into from Jan 22, 2021

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 11, 2021

Motivation for this change

See https://lists.gnu.org/archive/html/info-gnu/2021-01/msg00008.html
for release announcement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
Copy link
Contributor

r-burns commented Jan 24, 2021

This was failing to build on darwin and has been reverted in staging-next. Here's the failure log:

In file included from ./regexec.c:1362:
./malloc/dynarray-skeleton.c:195:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:195:13: error: expected ')'
./malloc/dynarray-skeleton.c:195:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:205:40: error: expected identifier or '('
__attribute_maybe_unused__ __nonnull ((1))
                                       ^
./malloc/dynarray-skeleton.c:205:40: error: expected ')'
./malloc/dynarray-skeleton.c:205:39: note: to match this '('
__attribute_maybe_unused__ __nonnull ((1))
                                      ^
./malloc/dynarray-skeleton.c:216:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:216:13: error: expected ')'
./malloc/dynarray-skeleton.c:216:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:225:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:225:13: error: expected ')'
./malloc/dynarray-skeleton.c:225:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:239:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:239:13: error: expected ')'
./malloc/dynarray-skeleton.c:239:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:248:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:248:13: error: expected ')'
./malloc/dynarray-skeleton.c:248:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:260:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:260:13: error: expected ')'
./malloc/dynarray-skeleton.c:260:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:270:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:270:13: error: expected ')'
./malloc/dynarray-skeleton.c:270:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:286:7: warning: implicit declaration of function 'regmatch_list_mark_failed' is invalid in C99 [-Wimplicit-function-declaration]
      DYNARRAY_NAME (mark_failed) (list);
      ^
./malloc/dynarray-skeleton.c:151:29: note: expanded from macro 'DYNARRAY_NAME'
#define DYNARRAY_NAME(name) DYNARRAY_CONCAT1(DYNARRAY_PREFIX, name)
                            ^
./malloc/dynarray-skeleton.c:150:40: note: expanded from macro 'DYNARRAY_CONCAT1'
#define DYNARRAY_CONCAT1(prefix, name) DYNARRAY_CONCAT0(prefix, name)
                                       ^
./malloc/dynarray-skeleton.c:149:40: note: expanded from macro 'DYNARRAY_CONCAT0'
#define DYNARRAY_CONCAT0(prefix, name) prefix##name
                                       ^
<scratch space>:154:1: note: expanded from here
regmatch_list_mark_failed
^
In file included from regex.c:74:
In file included from ./regexec.c:1362:
./malloc/dynarray-skeleton.c:297:13: error: expected identifier or '('
__nonnull ((1))
            ^
./malloc/dynarray-skeleton.c:297:13: error: expected ')'
./malloc/dynarray-skeleton.c:297:12: note: to match this '('
__nonnull ((1))
           ^
./malloc/dynarray-skeleton.c:342:7: warning: implicit declaration of function 'regmatch_list_mark_failed' is invalid in C99 [-Wimplicit-function-declaration]
      DYNARRAY_NAME (mark_failed) (list);
      ^
./malloc/dynarray-skeleton.c:151:29: note: expanded from macro 'DYNARRAY_NAME'
#define DYNARRAY_NAME(name) DYNARRAY_CONCAT1(DYNARRAY_PREFIX, name)
                            ^
./malloc/dynarray-skeleton.c:150:40: note: expanded from macro 'DYNARRAY_CONCAT1'
#define DYNARRAY_CONCAT1(prefix, name) DYNARRAY_CONCAT0(prefix, name)
                                       ^
./malloc/dynarray-skeleton.c:149:40: note: expanded from macro 'DYNARRAY_CONCAT0'
#define DYNARRAY_CONCAT0(prefix, name) prefix##name
                                       ^
<scratch space>:160:1: note: expanded from here
regmatch_list_mark_failed
^
In file included from regex.c:74:
In file included from ./regexec.c:1362:
./malloc/dynarray-skeleton.c:351:73: error: expected identifier or '('
__attribute_maybe_unused__ __attribute_warn_unused_result__ __nonnull ((1))
                                                                        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
2 warnings and 20 errors generated.
make[5]: *** [Makefile:2934: regex.o] Error 1

These are all files in gnulib, which was updated from upstream trunk right before the 4.8 release, so maybe it wasn't well-tested under clang?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants