Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytcc: 1.8.4 -> 2.0.1 #109088

Merged
merged 1 commit into from Jan 12, 2021
Merged

ytcc: 1.8.4 -> 2.0.1 #109088

merged 1 commit into from Jan 12, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 12, 2021

Motivation for this change

saw this in nixpkgs-update logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir
Copy link
Member

sikmir commented Jan 12, 2021

@jonringer Could you please apply these changes as well:

--- i/pkgs/tools/networking/ytcc/default.nix
+++ w/pkgs/tools/networking/ytcc/default.nix
@@ -15,21 +15,21 @@ python3Packages.buildPythonApplication rec {
 
   propagatedBuildInputs = with python3Packages; [ feedparser lxml sqlalchemy youtube-dl ];
 
-  checkInputs = with python3Packages; [ nose pytest ];
+  checkInputs = with python3Packages; [ nose pytestCheckHook ];
 
   # Disable tests that touch network or shell out to commands
-  checkPhase = ''
-    pytest . -k "not get_channels \
-                 and not play_video \
-                 and not download_videos \
-                 and not update_all \
-                 and not add_channel_duplicate"
-  '';
+  disabledTests = [
+    "get_channels"
+    "play_video"
+    "download_videos"
+    "update_all"
+    "add_channel_duplicate"
+  ];
 
   meta = {
     description = "Command Line tool to keep track of your favourite YouTube channels without signing up for a Google account";
     homepage = "https://github.com/woefe/ytcc";
-    license = lib.licenses.gpl3;
+    license = lib.licenses.gpl3Plus;
     maintainers = with lib.maintainers; [ marius851000 ];
   };
 }

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109088 run on x86_64-linux 1

1 package built:
  • ytcc

@jonringer
Copy link
Contributor Author

@sikmir done :)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109088 run on x86_64-darwin 1

1 package built:
  • ytcc

@jonringer jonringer merged commit 8aaba27 into NixOS:master Jan 12, 2021
@joachimschmidt557 joachimschmidt557 mentioned this pull request Feb 23, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants