New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
erlang: R22 -> R23 #109080
erlang: R22 -> R23 #109080
Conversation
I (webuhu) would encourage to upgrade Erlang default to v23. There exists this opinion: #87738 (comment)_ I in my opinion am always for update things fast (& let other things break ;). For external apps if things are not allowed to break the should anyway use pinned nixpkgs or fixed version. |
Unfortunately I'm not familiar enough with the Erlang ecosystem in Nix to be able to judge if this can be merged. I have only bumped Erlang versions within major releases. (Would love to see this go in, though!) (Btw, if I put on my code reviewer hat, I'd prefer to have the formatting changes in a separate commit, preferably in a different pull request. Right now the formatting changes are in a commit titled “erlang: R22 -> R23” within a pull request called “erlang: R22 -> R23”. :) |
@ehamberg thanks for the feedback. I'll make sure to separate the formatting before this goes in. |
Thanks! This looks good to me at a glance. I can try to run some tests this weekend, but don't let me hold this up. |
@yorickvP You're the last one who managed to update the major erlang version. Perhaps you have some time? otherwise maybe @LnL7 @goertzenator @andir can help? No worries if you are busy. |
Last time, I checked if it broke any packages and added overrides for them. The easiest way to separate the formatting is checkout master, nixfmt, commit, copy code from this, commit again. |
eb4108b
to
64ccbaa
Compare
@yorickvP thanks for the quick response! |
@vcunat @madjar @veprbl @Mic92 Also if anybody has any idea on how to get write permission, I'm interested in trying to get it, to be a maintainer of the Erlang/Elixir eco-system. |
Getting into |
... as for the push access itself, I don't know how it is now, but perhaps this thread is a good current reference. |
Should we create a BEAM group? https://github.com/NixOS/nixpkgs/blob/master/maintainers/team-list.nix |
@yurrriq amazing idea. I have an issue active around the elixir stuff, I'll post it there as well. |
Now that this gathered everyone interested in erlang in the same place, could anyone please review #107394 ? (this pr caused it to no longer apply, as did another recent one) |
Motivation for this change
Erlang 23 has been out for a while, I don't see any reason to hold back on using the latest version.
I only updated erlang to 23, using nixfmt, some lines were affected, I hope that's okay.
curious for feedback.
@FRidh
@alyssais
@mtanzi
@webuhu
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)