Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uboot: 2020.10 -> 2021.01 #109236

Merged
1 commit merged into from Jan 13, 2021
Merged

uboot: 2020.10 -> 2021.01 #109236

1 commit merged into from Jan 13, 2021

Conversation

samueldr
Copy link
Member

Motivation for this change

(Sadly they stopped doing actual changelogs)

Things done

I built every uboot packages:

 $ nix-build --keep-going --no-out-link \<nixpkgs\> -A pkgsCross.aarch64-multiplatform.ubootBananaPim64 -A pkgsCross.aarch64-multiplatform.ubootOdroidC2 -A pkgsCross.aarch64-multiplatform.ubootOrangePiZeroPlus2H5 -A pkgsCross.aarch64-multiplatform.ubootPine64 -A pkgsCross.aarch64-multiplatform.ubootPine64LTS -A pkgsCross.aarch64-multiplatform.ubootPinebook -A pkgsCross.aarch64-multiplatform.ubootPinebookPro -A pkgsCross.aarch64-multiplatform.ubootQemuAarch64 -A pkgsCross.aarch64-multiplatform.ubootROCPCRK3399 -A pkgsCross.aarch64-multiplatform.ubootRaspberryPi3_64bit -A pkgsCross.aarch64-multiplatform.ubootRaspberryPi4_64bit -A pkgsCross.aarch64-multiplatform.ubootRock64 -A pkgsCross.aarch64-multiplatform.ubootRockPi4 -A pkgsCross.aarch64-multiplatform.ubootRockPro64 -A pkgsCross.aarch64-multiplatform.ubootSopine
 $ nix-build --keep-going --no-out-link \<nixpkgs\> -A pkgsCross.armv7l-hf-multiplatform.ubootA20OlinuxinoLime -A pkgsCross.armv7l-hf-multiplatform.ubootAmx335xEVM -A pkgsCross.armv7l-hf-multiplatform.ubootBananaPi -A pkgsCross.armv7l-hf-multiplatform.ubootBananaPim3 -A pkgsCross.armv7l-hf-multiplatform.ubootBeagleboneBlack -A pkgsCross.armv7l-hf-multiplatform.ubootClearfog -A pkgsCross.armv7l-hf-multiplatform.ubootJetsonTK1 -A pkgsCross.armv7l-hf-multiplatform.ubootNovena -A pkgsCross.armv7l-hf-multiplatform.ubootOdroidXU3 -A pkgsCross.armv7l-hf-multiplatform.ubootOrangePiPc -A pkgsCross.armv7l-hf-multiplatform.ubootPcduino3Nano -A pkgsCross.armv7l-hf-multiplatform.ubootQemuArm -A pkgsCross.armv7l-hf-multiplatform.ubootRaspberryPi2 -A pkgsCross.armv7l-hf-multiplatform.ubootRaspberryPi3_32bit -A pkgsCross.armv7l-hf-multiplatform.ubootRaspberryPi4_32bit -A pkgsCross.armv7l-hf-multiplatform.ubootUtilite -A pkgsCross.armv7l-hf-multiplatform.ubootWandboard

All are building (as they did just before).

I have not tested it yet on hardware.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @petabyteboy @Mic92 @andir (recently showed interest in u-boot)

@SuperSandro2000
Copy link
Member

diff LGTM

@samueldr
Copy link
Member Author

Just in case: do not merge until it was verified to work on hardware for at least one board.

(It'd be nice to package and prep a test for QEMU.)

@ofborg ofborg bot requested review from dezgeg and lopsided98 January 13, 2021 02:23
@ghost
Copy link

ghost commented Jan 13, 2021

I got this message while building:

===================== WARNING ======================
CONFIG_OF_EMBED is enabled. This option should only
be used for debugging purposes. Please use
CONFIG_OF_SEPARATE for boards in mainline.
See doc/README.fdt-control for more info.
====================================================

But I'll ignore it if everything works, since I don't know if it's related to the update.

@ghost
Copy link

ghost commented Jan 13, 2021

Booted on the rpi 3 and rpi 4, each with the device-specific and latest kernel 👍

@ghost ghost merged commit 5ff4a67 into NixOS:master Jan 13, 2021
@samueldr samueldr deleted the updates/u-boot-2021.01 branch January 13, 2021 03:01
@samueldr
Copy link
Member Author

I got this message while building:

Yeah, their defconfig has the feature enabled.

Thanks for testing and merging!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @SuperSandro2000