Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex-oidc: 2.23.0 -> 2.27.0 #109237

Merged
merged 1 commit into from Jan 13, 2021
Merged

dex-oidc: 2.23.0 -> 2.27.0 #109237

merged 1 commit into from Jan 13, 2021

Conversation

benley
Copy link
Member

@benley benley commented Jan 12, 2021

Motivation for this change

Fixes #109155

Addresses CVE-2020-2690

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley benley requested a review from ckauhaus January 12, 2021 23:15
SuperSandro2000
SuperSandro2000 reviewed Jan 12, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildFlagsArray

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109237 run on x86_64-darwin 1

1 package built:
  • dex-oidc

@benley
Copy link
Member Author

benley commented Jan 13, 2021

buildFlagsArray

?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 13, 2021 •
edited

buildFlagsArray

?

I am pretty sure I wrote something similar to:

Could you add -s to buildFlagsArray?

Github must have lost it somewhere.

@ofborg ofborg bot requested a review from kalbasit January 13, 2021 02:36
@benley
Copy link
Member Author

benley commented Jan 13, 2021

Ahh, ok. What does adding -s do? Do you mean adding it to ldflags, where it would be akin to --strip-all?

@SuperSandro2000
Copy link
Member

Ahh, ok. What does adding -s do? Do you mean adding it to ldflags, where it would be akin to --strip-all?

It strips. Yes please add it so ldflags but as it as -s to easier grep for it

@benley
Copy link
Member Author

benley commented Jan 13, 2021

Ahh, ok. What does adding -s do? Do you mean adding it to ldflags, where it would be akin to --strip-all?

It strips. Yes please add it so ldflags but as it as -s to easier grep for it

OK, done.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109237 run on x86_64-linux 1

1 package built:
  • dex-oidc

@SuperSandro2000 SuperSandro2000 merged commit fc748c2 into NixOS:master Jan 13, 2021
@benley benley deleted the dex-2.27.0 branch January 13, 2021 19:06
@FliegendeWurst FliegendeWurst mentioned this pull request Dec 11, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ckauhaus ckauhaus Awaiting requested review from ckauhaus

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 98: dex-2.23.0: 1 advisory [9.6]
2 participants
@benley @SuperSandro2000