Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: Add debugging symbols in development builds #109239

Merged
merged 2 commits into from Jan 27, 2021
Merged

qt5: Add debugging symbols in development builds #109239

merged 2 commits into from Jan 27, 2021

Conversation

poelzi
Copy link
Member

@poelzi poelzi commented Jan 12, 2021

qt5 build with developerBuild do not contain debug information as
they are stripped by the qt build process.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@poelzi poelzi requested a review from ttuegel as a code owner January 12, 2021 23:24
@ofborg ofborg bot requested review from qknight, bkchr and periklis January 13, 2021 02:53
@FRidh
Copy link
Member

FRidh commented Jan 13, 2021

See also #108888.

@poelzi
Copy link
Member Author

poelzi commented Jan 18, 2021

Can we please merge this, otherwise debugging more complex qt problems is impossible

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2021

/rebase-staging

poelzi and others added 2 commits January 18, 2021 19:56
@poelzi @github-actions
qt5: Add debugging symbols in development builds
f26043e 
qt5 build with developerBuild do not contain debug information as
they are stripped by the qt build process.
@poelzi @SuperSandro2000 @github-actions
Update pkgs/development/libraries/qt-5/modules/qtbase.nix
0c0d5a2 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@github-actions github-actions bot changed the base branch from master to staging January 18, 2021 19:56
@Mic92 Mic92 merged commit 8f69090 into NixOS:staging Jan 27, 2021
@TredwellGit
Copy link
Member

Attribute 'dontStrip' at qtbase.nix:408:3 already defined at qtbase.nix:169:3.

@FRidh
Copy link
Member

FRidh commented Jan 27, 2021

@GrahamcOfBorg eval

Mic92 added a commit that referenced this pull request Jan 27, 2021
@Mic92
Revert "Merge pull request #109239 from poelzi/qt-debug-symbols"
d72ebea 
This reverts commit 8f69090, reversing
changes made to e6a8527.

In 13e3ec0 this was already addressed
@Mic92
Copy link
Member

Mic92 commented Jan 27, 2021

reverted in d72ebea
something similar was already done in 13e3ec0

andir pushed a commit to andir/nixpkgs that referenced this pull request Jan 30, 2021
@Mic92
Revert "Merge pull request NixOS#109239 from poelzi/qt-debug-symbols"
05cf9e5 
This reverts commit 8f69090, reversing
changes made to e6a8527.

In 13e3ec0 this was already addressed
dasj19 pushed a commit to dasj19/nixpkgs that referenced this pull request Feb 11, 2021
@Mic92 @dasj19
Revert "Merge pull request NixOS#109239 from poelzi/qt-debug-symbols"
6af5084 
This reverts commit 8f69090, reversing
changes made to e6a8527.

In 13e3ec0 this was already addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@qknight qknight Awaiting requested review from qknight

@bkchr bkchr Awaiting requested review from bkchr

@periklis periklis Awaiting requested review from periklis

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@poelzi @FRidh @Mic92 @TredwellGit @SuperSandro2000