Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridNG] Apply justify-content, alignment-content. #27158

Merged
merged 1 commit into from Jan 21, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 12, 2021

As above. This patch implements the core content alignment logic. E.g.
determining the offset at which the tracks should start, and the space
between them (gutter-size - this include the grid-gap if any).

Creates a new struct "TrackAlignmentGeometry" which contains these
two values. Effectively the process is now:
GridGap -> TrackAlignmentGeometry -> SetOffsets.

The most significant difference is that TrackAlignmentGeometry includes
the grid-gap, and the BorderScrollPadding start offset.

Bug: 1045599
Change-Id: Idb4d550f0d8b2aca306945a46d41b5a30a20bca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622586
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845494}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

As above. This patch implements the core content alignment logic. E.g.
determining the offset at which the tracks should start, and the space
between them (gutter-size - this include the grid-gap if any).

Creates a new struct "TrackAlignmentGeometry" which contains these
two values. Effectively the process is now:
GridGap -> TrackAlignmentGeometry -> SetOffsets.

The most significant difference is that TrackAlignmentGeometry includes
the grid-gap, and the BorderScrollPadding start offset.

Bug: 1045599
Change-Id: Idb4d550f0d8b2aca306945a46d41b5a30a20bca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622586
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845494}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants