Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbb: 2019_U9 -> 2021.1.1 #109113

Closed
wants to merge 3 commits into from
Closed

tbb: 2019_U9 -> 2021.1.1 #109113

wants to merge 3 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 12, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 12, 2021

Have not check breakages with dependent packages yet.

@@ -1,36 +1,26 @@
{ stdenv, fetchFromGitHub, fixDarwinDylibNames, compiler ? if stdenv.cc.isClang then "clang" else null, stdver ? null }:
Copy link
Member Author

@Mic92 Mic92 Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think specifying a compiler is needed anymore.
Otherwise using overrideAttrs to set cmakeFlags should be easy enough. same for setting the c++ standard.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109113 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • cq-editor
  • pdal
  • sysdig
16 packages failed to build and are new build failures:
  • blender: log was empty
  • bowtie2: log was empty
  • embree: log was empty
  • inkcut: log was empty
  • openimagedenoise: log was empty
  • python37Packages.cadquery: log was empty
  • python37Packages.enamlx: log was empty
  • python37Packages.pythonocc-core: log was empty
  • python37Packages.tiledb: log was empty
  • python38Packages.enamlx: log was empty
  • python38Packages.pythonocc-core: log was empty
  • python38Packages.tiledb: log was empty
  • python39Packages.enamlx: log was empty
  • python39Packages.pythonocc-core: log was empty
  • tbb: log https://termbin.com/d5df
  • tiledb: log was empty

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2021

@SuperSandro2000 looks like your build run out of memory. Could you try again?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 13, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109113 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • cq-editor
  • pdal
  • sysdig
16 packages failed to build and are new build failures:
  • blender: log was empty
  • bowtie2: log was empty
  • embree: log was empty
  • inkcut: log was empty
  • openimagedenoise: log was empty
  • python37Packages.cadquery: log was empty
  • python37Packages.enamlx: log was empty
  • python37Packages.pythonocc-core: log was empty
  • python37Packages.tiledb: log was empty
  • python38Packages.enamlx: log was empty
  • python38Packages.pythonocc-core: log was empty
  • python38Packages.tiledb: log was empty
  • python39Packages.enamlx: log was empty
  • python39Packages.pythonocc-core: log was empty
  • tbb: log https://termbin.com/bf20
  • tiledb: log was empty

@Mic92 same error I think.

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2021

Should be fixed now.

};

nativeBuildInputs = optional stdenv.isDarwin fixDarwinDylibNames;
nativeBuildInputs = [ cmake ] ++ optional stdenv.isDarwin fixDarwinDylibNames;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if fixDarwinDylibNames is still required.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109113 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • cq-editor
  • pdal
  • sysdig
10 packages failed to build and are new build failures:
  • blender: log was empty
  • inkcut: log was empty
  • openimagedenoise: log https://termbin.com/13kg
  • python37Packages.cadquery: log was empty
  • python37Packages.enamlx: log was empty
  • python37Packages.pythonocc-core: log was empty
  • python38Packages.enamlx: log was empty
  • python38Packages.pythonocc-core: log was empty
  • python39Packages.enamlx: log was empty
  • python39Packages.pythonocc-core: log was empty
6 packages built:
  • bowtie2
  • embree
  • python37Packages.tiledb
  • python38Packages.tiledb
  • tbb
  • tiledb

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2021

Fixed openimagedenoise build.

@ofborg ofborg bot requested a review from aristidb January 13, 2021 17:01
@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2021

openvdb is not yet compatible: AcademySoftwareFoundation/openvdb#887

@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2021

cc @guibou regarding openvdb

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109113 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • cq-editor
  • pdal
  • sysdig
9 packages failed to build and are new build failures:
  • blender: log https://termbin.com/r2hz
  • inkcut: log was empty
  • python37Packages.cadquery: log was empty
  • python37Packages.enamlx: log was empty
  • python37Packages.pythonocc-core: log was empty
  • python38Packages.enamlx: log was empty
  • python38Packages.pythonocc-core: log was empty
  • python39Packages.enamlx: log was empty
  • python39Packages.pythonocc-core: log was empty
8 packages built:
  • bowtie2
  • embree
  • ispc
  • openimagedenoise
  • python37Packages.tiledb
  • python38Packages.tiledb
  • tbb
  • tiledb

@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2021

blender also needs to be fixed for this can be merged.

@Mic92 Mic92 marked this pull request as draft January 15, 2021 10:17
@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2021

Opened a blender ticket here: https://developer.blender.org/T84745

@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2021

They did not like the ticket and suggested me to write on their discourse: https://devtalk.blender.org/t/incompatible-with-tbb-2021-1-1/17102

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109113 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • hhvm
  • linuxPackages_4_4.sysdig
  • linuxPackages_4_9.sysdig
  • linuxPackages_hardkernel_4_14.sysdig
  • linuxPackages_hardkernel_latest.sysdig
47 packages failed to build and are new build failures:
  • anki-bin: log was empty
  • appimage-run: log was empty
  • blender: log was empty
  • cloudcompare: log https://termbin.com/wzsb
  • cq-editor: log was empty
  • deltachat-electron: log was empty
  • devdocs-desktop: log was empty
  • electronplayer: log was empty
  • embree2: log https://termbin.com/onr8
  • horizon-eda: log was empty
  • ikos: log https://termbin.com/enbf
  • inkcut: log was empty
  • inkscape-extensions.inkcut: log was empty
  • irccloud: log was empty
  • keeweb: log was empty
  • ledger-live-desktop: log was empty
  • lens: log was empty
  • linuxPackages-libre.sysdig: log was empty
  • lunar-client: log was empty
  • luxcorerender: log was empty
  • mirtk: log https://termbin.com/lhds
  • molotov: log was empty
  • nuclear: log was empty
  • openvdb: log https://termbin.com/tpcr
  • openxray: log https://termbin.com/luy6
  • osrm-backend: log https://termbin.com/qi41
  • p3x-onenote: log was empty
  • paraview: log https://termbin.com/anwv
  • prusa-slicer: log was empty
  • python37Packages.cadquery: log was empty
  • python37Packages.enamlx: log was empty
  • python37Packages.pythonocc-core: log was empty
  • python38Packages.enamlx: log was empty
  • python38Packages.pythonocc-core: log was empty
  • python39Packages.enamlx: log was empty
  • python39Packages.pythonocc-core: log was empty
  • radicle-upstream: log was empty
  • runwayml: log was empty
  • ssb-patchwork: log was empty
  • standardnotes: log was empty
  • steam-run-native: log was empty
  • super-slicer: log was empty
  • timeular: log was empty
  • tracy: log https://termbin.com/ztxp
  • unityhub: log was empty
  • wootility: log was empty
  • zulip: log was empty
37 packages built:
  • Sylk
  • bowtie2
  • chrysalis
  • embree
  • ispc
  • joplin-desktop
  • linuxPackages.sysdig (linuxPackages_5_4.sysdig)
  • linuxPackages_4_14.sysdig
  • linuxPackages_4_19.sysdig
  • linuxPackages_5_10.sysdig (linuxPackages_latest.sysdig)
  • linuxPackages_5_9.sysdig
  • linuxPackages_hardened.sysdig
  • linuxPackages_latest-libre.sysdig
  • linuxPackages_latest_hardened.sysdig
  • linuxPackages_latest_xen_dom0.sysdig
  • linuxPackages_latest_xen_dom0_hardened.sysdig
  • linuxPackages_lqx.sysdig
  • linuxPackages_testing_bcachefs.sysdig
  • linuxPackages_xen_dom0.sysdig
  • linuxPackages_xen_dom0_hardened.sysdig
  • linuxPackages_zen.sysdig
  • marktext
  • minetime
  • mycrypto
  • notable
  • openimagedenoise
  • pdal
  • plexamp
  • python37Packages.tiledb
  • python38Packages.tiledb
  • station
  • sysdig
  • tbb
  • tiledb
  • tusk
  • unity3d
  • zettlr

@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2021

Look like we need to keep the old version as well. There are too many incompatible projects out there.

@Mic92
Copy link
Member Author

Mic92 commented May 12, 2021

If some else ones to takes this over...

@Mic92 Mic92 deleted the tbb branch July 23, 2021 08:30
@jtojnar jtojnar mentioned this pull request Oct 10, 2022
13 tasks
@jtojnar jtojnar mentioned this pull request Feb 6, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants