New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tbb: 2019_U9 -> 2021.1.1 #109113
tbb: 2019_U9 -> 2021.1.1 #109113
Conversation
Have not check breakages with dependent packages yet. |
@@ -1,36 +1,26 @@ | |||
{ stdenv, fetchFromGitHub, fixDarwinDylibNames, compiler ? if stdenv.cc.isClang then "clang" else null, stdver ? null }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think specifying a compiler is needed anymore.
Otherwise using overrideAttrs
to set cmakeFlags should be easy enough. same for setting the c++ standard.
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages marked as broken and skipped:
16 packages failed to build and are new build failures:
|
@SuperSandro2000 looks like your build run out of memory. Could you try again? |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages marked as broken and skipped:
16 packages failed to build and are new build failures:
@Mic92 same error I think. |
Should be fixed now. |
}; | ||
|
||
nativeBuildInputs = optional stdenv.isDarwin fixDarwinDylibNames; | ||
nativeBuildInputs = [ cmake ] ++ optional stdenv.isDarwin fixDarwinDylibNames; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if fixDarwinDylibNames
is still required.
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages marked as broken and skipped:
10 packages failed to build and are new build failures:
6 packages built:
|
Fixed openimagedenoise build. |
openvdb is not yet compatible: AcademySoftwareFoundation/openvdb#887 |
cc @guibou regarding openvdb |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages marked as broken and skipped:
9 packages failed to build and are new build failures:
8 packages built:
|
blender also needs to be fixed for this can be merged. |
Opened a blender ticket here: https://developer.blender.org/T84745 |
They did not like the ticket and suggested me to write on their discourse: https://devtalk.blender.org/t/incompatible-with-tbb-2021-1-1/17102 |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 5 packages marked as broken and skipped:
47 packages failed to build and are new build failures:
37 packages built:
|
Look like we need to keep the old version as well. There are too many incompatible projects out there. |
If some else ones to takes this over... |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)