Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break various dependency cycles #109093

Merged
merged 1 commit into from Jan 12, 2021
Merged

Break various dependency cycles #109093

merged 1 commit into from Jan 12, 2021

Conversation

poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Jan 12, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Break the following dependency cycles
3fa0bf0 
               (testdep)
1. tasty-hedgehog <-> tasty-expected-failure

              (testdep)
2. lifted-async ---> tasty-hedgehog -> hedgehog -> lifted-async
@cdepillabout
Copy link
Member

Thanks, I've confirmed that all these related now build.

@cdepillabout cdepillabout merged commit 0d4fdba into NixOS:haskell-updates Jan 12, 2021
@poscat0x04 poscat0x04 deleted the break-tasty-cycle branch January 13, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poscat0x04 @cdepillabout