Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.strictyaml: 1.1.1 -> 1.3.0 #109072

Merged
merged 1 commit into from Jan 12, 2021
Merged

python3Packages.strictyaml: 1.1.1 -> 1.3.0 #109072

merged 1 commit into from Jan 12, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 12, 2021 •
edited

Motivation for this change

routine bump of packages I maintain

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner January 12, 2021 02:29
@jonringer
Copy link
Contributor Author

failures broken on master:

https://github.com/NixOS/nixpkgs/pull/109072

1 package failed to build:
devpi-client

4 packages built:
devpi-server python37Packages.strictyaml python38Packages.strictyaml python39Packages.strictyaml

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109072 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • devpi-client: log was empty
4 packages built:
  • devpi-server
  • python37Packages.strictyaml
  • python38Packages.strictyaml
  • python39Packages.strictyaml

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109072 run on x86_64-darwin 1

2 packages failed to build and are new build failures:
3 packages built:
  • python37Packages.strictyaml
  • python38Packages.strictyaml
  • python39Packages.strictyaml

@SuperSandro2000 SuperSandro2000 merged commit b5dc4d3 into NixOS:master Jan 12, 2021
@jonringer jonringer deleted the bump-strict-yaml branch February 13, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SuperSandro2000