Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomuks: 0.2.1 -> 0.2.2 #109115

Merged
merged 1 commit into from Jan 13, 2021
Merged

gomuks: 0.2.1 -> 0.2.2 #109115

merged 1 commit into from Jan 13, 2021

Conversation

chvp
Copy link
Member

@chvp chvp commented Jan 12, 2021

Motivation for this change

Package bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, emilazy and tilpner January 12, 2021 15:06
@hugolgst
Copy link
Member

Result of nixpkgs-review pr 109115 1

1 package built:
  • gomuks

hugolgst
hugolgst approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuperSandro2000
SuperSandro2000 reviewed Jan 12, 2021
View reviewed changes
pkgs/applications/networking/instant-messengers/gomuks/default.nix Outdated
@@ -2,16 +2,16 @@

buildGoModule rec {
pname = "gomuks";
version = "0.2.1";
version = "0.2.2";

src = fetchFromGitHub {
owner = "tulir";
repo = pname;
rev = "v" + version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v" + version;
rev = "v${version}";

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109115 run on x86_64-darwin 1

1 package built:
  • gomuks

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109115 run on x86_64-linux 1

1 package built:
  • gomuks

@SuperSandro2000 SuperSandro2000 merged commit c05e2bc into NixOS:master Jan 13, 2021
@chvp chvp deleted the pr/bump-gomuks branch January 13, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@hugolgst hugolgst hugolgst approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@emilazy emilazy Awaiting requested review from emilazy

@tilpner tilpner Awaiting requested review from tilpner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chvp @hugolgst @SuperSandro2000