blink: makes display lock use overflow-clip-rect when appropriate #27159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 13, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2626027
branch
5 times, most recently
from
ff54188
to
5771058
Compare
Specifically, if the box has non visible overflow and an overflow-clip-margin. Without this the overflow from contain:paint doesn't take into the account the overflow-clip-margin, and we may end up not painting when we should. BUG=1157843 TEST=third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-clip-margin-007.html Change-Id: Iba11a683f8cc1eb595ef26984c0dce38133fc760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626027 Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844846}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2626027
branch
from
5771058
to
e2e5ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, if the box has non visible overflow and
an overflow-clip-margin. Without this the overflow from
contain:paint doesn't take into the account the overflow-clip-margin,
and we may end up not painting when we should.
BUG=1157843
TEST=third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-clip-margin-007.html
Change-Id: Iba11a683f8cc1eb595ef26984c0dce38133fc760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626027
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844846}