Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsd: fix build #109101

Merged
merged 2 commits into from Jan 12, 2021
Merged

xsd: fix build #109101

merged 2 commits into from Jan 12, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 12, 2021 •
edited

last release 2014... does not build with gcc10

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
xsd: fix build
a8c0716 
last release 2014... does not build with gcc10
@Mic92
xsd: modernize build
37edb33
@ofborg ofborg bot requested a review from jagajaga January 12, 2021 11:46
@Mic92
Copy link
Member Author

Mic92 commented Jan 12, 2021

@GrahamcOfBorg build xsd

@Mic92 Mic92 merged commit 5322c1f into NixOS:master Jan 12, 2021
@Mic92 Mic92 deleted the xsd branch January 12, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92