Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oraclejdk8: 8u261 -> 8u271 #109055

Merged
merged 1 commit into from Jan 12, 2021
Merged

oraclejdk8: 8u261 -> 8u271 #109055

merged 1 commit into from Jan 12, 2021

Conversation

bbjubjub2494
Copy link
Member

@bbjubjub2494 bbjubjub2494 commented Jan 11, 2021

Motivation for this change

Old package cannot be built anymore.

Things done

Bump version, fix hashes. Address a concern about the aarch64 source having changed name.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494 bbjubjub2494 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 11, 2021
@bbjubjub2494
Copy link
Member Author

ping #108810 (running tests rn, will undraft after)

@SuperSandro2000
Copy link
Member

Is there a reason like security patches why we should port this to stable?

@bbjubjub2494
Copy link
Member Author

nix run nixos#nixpkgs-review pr 109055 on x86_64:

https://github.com/NixOS/nixpkgs/pull/109055
9 packages built:
docear ib-controller ib-tws javacard-devkit jre8Plugin oraclejdk oraclejre processing sqldeveloper

on aarch64 (in both cases I had to manually download 3 unfree packages btw)

https://github.com/NixOS/nixpkgs/pull/109055
6 packages built:
docear ib-controller ib-tws jre8Plugin oraclejdk oraclejre

Also on aarch64

$ result/bin/java -version
java version "1.8.0_271"
Java(TM) SE Runtime Environment (build 1.8.0_271-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.271-b09, mixed mode)

@bbjubjub2494
Copy link
Member Author

Is there a reason like security patches why we should port this to stable?

not afaict. However, outdated version cannot be found on the internet, so it's basically unusable if you haven't installed it already. There's also precedent for backporting at 9659dbd.

@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review January 11, 2021 23:05
@bbjubjub2494
Copy link
Member Author

on i686:

nix run nixos#legacyPackages.i686-linux.nixpkgs-review pr 109055
[...]
7 packages built:
docear ib-controller ib-tws javacard-devkit jre8Plugin oraclejdk oraclejre

@kini
Copy link
Member

kini commented Jan 12, 2021

However, outdated version cannot be found on the internet, so it's basically unusable if you haven't installed it already.

Old versions are actually still available at https://www.oracle.com/java/technologies/javase/javase8u211-later-archive-downloads.html but their use is highly discouraged by upstream, because "u" version bumps typically include security patches. For example, 8u261 is affected by most of the CVEs in this table: https://www.oracle.com/security-alerts/cpuoct2020.html#AppendixJAVA

@Ma27
Copy link
Member

Ma27 commented Jan 12, 2021

Ported to stable as 0fc1862.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 12, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/java-webstart-nixos-18-09/1136/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants