Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pam: fix musl build #109145

Closed
wants to merge 1 commit into from
Closed

pam: fix musl build #109145

wants to merge 1 commit into from

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Jan 12, 2021

Motivation for this change

The musl build was broken in #107185 because the patch does not apply cleanly any more.
Since the issue addressed by the patch was fixed in 1.4.0, it can be removed.

CC @NeQuissimus

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Jan 12, 2021

@GrahamcOfBorg build linux-pam
@GrahamcOfBorg build pkgsMusl.linux-pam

@pjjw
Copy link
Contributor

pjjw commented Jan 20, 2021

sorry, looks obviated by #109906

@kampka kampka closed this Jan 20, 2021
@kampka kampka deleted the linux-pam branch January 20, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @pjjw @NeQuissimus