Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3, i3-gaps: 4.18.3 -> 4.19 #109106

Merged
merged 1 commit into from Jan 12, 2021
Merged

i3, i3-gaps: 4.18.3 -> 4.19 #109106

merged 1 commit into from Jan 12, 2021

Conversation

marzzzello
Copy link
Contributor

@marzzzello marzzzello commented Jan 12, 2021 •
edited

Upstream switched from the autotools build system to the meson build system.
Also the source archive format switched from tar.bz2 to tar.xz
The build now supports application documentation in /share/doc/i3/
https://i3wm.org/downloads/RELEASE-NOTES-4.19.txt

Motivation for this change

New features and fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marzzzello marzzzello marked this pull request as ready for review January 12, 2021 12:18
@ofborg ofborg bot requested review from fmthoma, globin and fpletz January 12, 2021 12:46
@marzzzello
Copy link
Contributor Author

marzzzello commented Jan 12, 2021 •
edited

i3-gaps and python39Packages.powerline are failing. i3-gaps also switched to the new build system. I already have i3-gaps working with 4.19. Should I do a separate PR or how to proceed?

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/marcel/.cache/nixpkgs-review/pr-109106-2/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/j6irxp0p0f26p8al5f1pvy344kk01abx-i3-gaps-4.18.3.drv' failed with exit code 1; last 10 log lines:
  autoreconf: running: /nix/store/var821ibfzbhjk911z4b1h5xhxc3pfl5-autoconf-2.70/bin/autoheader --force
  autoreconf: running: automake --add-missing --copy --force-missing
  Makefile.am:229: warning: '%'-style pattern rules are a GNU make extension
  autoreconf: './config.sub' is updated
  autoreconf: './config.guess' is updated
  autoreconf: Leaving directory '.'
  configuring
  meson flags: --buildtype=plain         --libdir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/lib --libexecdir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/libexec         --bindir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/bin --sbindir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/sbin         --includedir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/include         --mandir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/share/man --infodir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/share/info         --localedir=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/41wh68b6sqgy53kql7937yxyaa5y18l2-i3-gaps-4.18.3  
  
  ERROR: Neither directory contains a build file meson.build.
builder for '/nix/store/f8gfdpqmjvb5lbf3wm824jszh6fc2iq1-python3.9-pyuv-1.2.0.drv' failed with exit code 1; last 10 log lines:
  src/pyuv.c:72:5: warning: ‘PyEval_InitThreads’ is deprecated [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
     72 |     PyEval_InitThreads();
        |     ^~~~~~~~~~~~~~~~~~
  In file included from /nix/store/3g9596lia3mdr753amydqs6ilr4iaf1m-python3-3.9.1/include/python3.9/Python.h:145,
                   from src/pyuv.h:7,
                   from src/pyuv.c:2:
  /nix/store/3g9596lia3mdr753amydqs6ilr4iaf1m-python3-3.9.1/include/python3.9/ceval.h:130:37: note: declared here
    130 | Py_DEPRECATED(3.9) PyAPI_FUNC(void) PyEval_InitThreads(void);
        |                                     ^~~~~~~~~~~~~~~~~~
  error: command '/nix/store/d2fqghv083a8q7j8sjb2m5q6i840h691-gcc-wrapper-10.2.0/bin/gcc' failed with exit code 1
cannot build derivation '/nix/store/cyijpz2r2kpb1qv0ccamzs6shgjlgji3-python3.9-powerline-2.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fb4dn34ik8bxsb6a1nql54r7rz29dg6l-env.drv': 2 dependencies couldn't be built
[0 built (2 failed), 0.0 MiB DL]
error: build of '/nix/store/fb4dn34ik8bxsb6a1nql54r7rz29dg6l-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/109106
2 packages failed to build:
i3-gaps python39Packages.powerline

20 packages built:
autotiling flashfocus i3 i3-balance-workspace i3-layout-manager i3-resurrect i3-wk-switch i3altlayout polybarFull powerline python37Packages.i3ipc python37Packages.powerline python37Packages.py3status python38Packages.i3ipc python38Packages.py3status python39Packages.i3ipc python39Packages.py3status raiseorlaunch sway-contrib.inactive-windows-transparency xkb-switch-i3

SuperSandro2000
SuperSandro2000 reviewed Jan 12, 2021
View reviewed changes
pkgs/applications/window-managers/i3/default.nix Outdated
};

nativeBuildInputs = [ which pkgconfig makeWrapper installShellFiles ];
nativeBuildInputs = [ which pkgconfig makeWrapper meson ninja installShellFiles ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still require which and pkg-config?

If so please change pkgconfig to pkg-config.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 12, 2021 •
edited

Should I do a separate PR or how to proceed?

You can add it to here.

@jonringer
Copy link
Contributor

the current i3-gaps just overrides the i3 package, we may want to keep a i3_4_18 package so that i3 is able to build.

related: Airblader/i3#381

@marzzzello
i3, i3-gaps: 4.18.3 -> 4.19
af56bbf 
Upstream switched from the autotools build system to the meson build system.
Also the source archive format switched from tar.bz2 to tar.xz
The build now supports application documentation in /share/doc/i3/
https://i3wm.org/downloads/RELEASE-NOTES-4.19.txt
@marzzzello marzzzello changed the title i3: 4.18.3 -> 4.19 i3, i3-gaps: 4.18.3 -> 4.19 Jan 12, 2021
@marzzzello
Copy link
Contributor Author

I removed which and changed pkgconfig to pkg-config.
And I added i3-gaps.
python39Packages.powerline still fails to build.
Any ideas how to fix this? @SuperSandro2000

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/marcel/.cache/nixpkgs-review/pr-109106-4/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/f8gfdpqmjvb5lbf3wm824jszh6fc2iq1-python3.9-pyuv-1.2.0.drv' failed with exit code 1; last 10 log lines:
  src/pyuv.c:72:5: warning: ‘PyEval_InitThreads’ is deprecated [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
     72 |     PyEval_InitThreads();
        |     ^~~~~~~~~~~~~~~~~~
  In file included from /nix/store/3g9596lia3mdr753amydqs6ilr4iaf1m-python3-3.9.1/include/python3.9/Python.h:145,
                   from src/pyuv.h:7,
                   from src/pyuv.c:2:
  /nix/store/3g9596lia3mdr753amydqs6ilr4iaf1m-python3-3.9.1/include/python3.9/ceval.h:130:37: note: declared here
    130 | Py_DEPRECATED(3.9) PyAPI_FUNC(void) PyEval_InitThreads(void);
        |                                     ^~~~~~~~~~~~~~~~~~
  error: command '/nix/store/d2fqghv083a8q7j8sjb2m5q6i840h691-gcc-wrapper-10.2.0/bin/gcc' failed with exit code 1
cannot build derivation '/nix/store/s5p8jclks8j34sp395b0640br985xknh-python3.9-powerline-2.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kla3rfr9pczssss5l53milhhq09wdmbk-env.drv': 1 dependencies couldn't be built
[25 built (1 failed), 1 copied (0.2 MiB), 0.0 MiB DL]
error: build of '/nix/store/kla3rfr9pczssss5l53milhhq09wdmbk-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/109106
1 package failed to build:
python39Packages.powerline

21 packages built:
autotiling flashfocus i3 i3-balance-workspace i3-gaps i3-layout-manager i3-resurrect i3-wk-switch i3altlayout polybarFull powerline python37Packages.i3ipc python37Packages.powerline python37Packages.py3status python38Packages.i3ipc python38Packages.py3status python39Packages.i3ipc python39Packages.py3status raiseorlaunch sway-contrib.inactive-windows-transparency xkb-switch-i3

@jonringer
Copy link
Contributor

python39Packages.powerline was failing before, and broken on master, don't worry about that one

jonringer
jonringer approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python39Packages.powerline

21 packages built:
autotiling flashfocus i3 i3-balance-workspace i3-gaps i3-layout-manager i3-resurrect i3-wk-switch i3altlayout polybarFull powerline python37Packages.i3ipc python37Packages.powerline python37Packages.py3status python38Packages.i3ipc python38Packages.py3status python39Packages.i3ipc python39Packages.py3status raiseorlaunch sway-contrib.inactive-windows-transparency xkb-switch-i3

@jonringer
Copy link
Contributor

waiting for ofborg

@SuperSandro2000 SuperSandro2000 merged commit aa401c3 into NixOS:master Jan 12, 2021
@marzzzello marzzzello deleted the i3-update branch January 12, 2021 18:21
jneo8 added a commit to jneo8/dotfiles that referenced this pull request Feb 18, 2021
@jneo8
fix(install-i3-gaps.sh): set i3 gaps to specific version to build
095308c 
See NixOS/nixpkgs#109106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@fmthoma fmthoma Awaiting requested review from fmthoma

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marzzzello @SuperSandro2000 @jonringer @Janik-Haag