Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: enable display core support for all amd gpus #109105

Merged
merged 1 commit into from Feb 15, 2021
Merged

linux: enable display core support for all amd gpus #109105

merged 1 commit into from Feb 15, 2021

Conversation

wakira
Copy link
Member

@wakira wakira commented Jan 12, 2021

This PR enables all DC related kernel configs for NixOS (other distros such as arch and fedora enable them by default)

Motivation for this change

AMD's RX6000 series GPU requires drm display core (DC) support compiled to properly detect outputs.

More discussions in previous PR: #107400

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wakira wakira mentioned this pull request Jan 12, 2021
Closed
10 tasks
@SuperSandro2000
Copy link
Member

/rebase-staging

@wakira @github-actions
linux: enable display core support for all amd gpus
57c9a0d 
newer amd gpus require display core to function normally
@github-actions github-actions bot changed the base branch from master to staging January 12, 2021 14:56
@Artturin
Copy link
Member

Artturin commented Jan 12, 2021 •
edited

can you explain why the whenBetween's are needed

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 13, 2021 •
edited

@gebner I don't think this is mission critically or preventing unstable from advancing so I wanted to avoid the 1000+ rebuilds and potentially holding of builds in master and by that also merging other PRs because we potentially can't test them.

@wakira
Copy link
Member Author

wakira commented Jan 13, 2021

can you explain why the whenBetween's are needed

I don't want to introduce configs that is unavailable to the building kernel's version.
For example, after kernel 5.6 DRM_AMD_DC_DCN2_1 no longer exists and DC support is enabled by default for these devices.

@gebner
Copy link
Member

gebner commented Jan 13, 2021

@SuperSandro2000 Kernel rebuilds don't hold up anything else so they should be fine. In particular it doesn't prevent us from testing other PRs, like a change to e.g. glib would. It's just that we have lots of kernel modules.

@SuperSandro2000
Copy link
Member

Kernel rebuilds don't hold up anything

I needed to compile several kernels over the last days and it always held up my review cycle by hours if I did not skip those PRs.

testing other PRs

It does for kernel modules. If nixpkgs-review starts to build 5 kernels for me then I can't check kernel modules at all.

So I am not a big fan of this.

@gebner
Copy link
Member

gebner commented Jan 13, 2021

Ah, okay. This makes sense.

@Artturin
Copy link
Member

ping so that this does not become stale

@Oro
Copy link
Contributor

Oro commented Feb 14, 2021

My 2 cents//testing (at least I hope that this helps a potential reviewer/merger): With these kernel patches (as within this PR) an AMD 6800XT on kernel 5.10.12 actually displays. Without any kernel patches it would just stay blank.

DRM_AMD_DC_DCN3_0 y
DRM_AMD_DC_HDCP y
DRM_AMD_DC_SI y

@lheckemann lheckemann merged commit e1580db into NixOS:staging Feb 15, 2021
@Mic92
Copy link
Member

Mic92 commented Feb 15, 2021

I think this broke evaluation for me: https://gist.github.com/GrahamcOfBorg/8190da20051fac281849dc5ac35489ec

@Mic92
Copy link
Member

Mic92 commented Feb 15, 2021

Issue is that #111177 was also merged.

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Feb 15, 2021
@Mic92
linux: fix DRM_AMD_DC_DCN3_0 beeing defined twice
09176d2 
both NixOS#111177 and
NixOS#109105

introduced the same option.
@Mic92
Copy link
Member

Mic92 commented Feb 15, 2021

Fix in #113156

@B4dM4n B4dM4n mentioned this pull request Feb 18, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann Awaiting requested review from lheckemann

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wakira @SuperSandro2000 @Artturin @gebner @Oro @Mic92 @lheckemann