Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.9.4p2 -> 1.9.5p1 #109082

Merged
merged 1 commit into from Jan 15, 2021
Merged

sudo: 1.9.4p2 -> 1.9.5p1 #109082

merged 1 commit into from Jan 15, 2021

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jan 12, 2021

Motivation for this change

Changelog: https://www.sudo.ws/stable.html

Tested: nix-build nixos/tests/sudo.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra January 12, 2021 05:58
@lukegb
Copy link
Contributor

lukegb commented Jan 12, 2021

Fixes CVE-2021-23239 and CVE-2021-23240, which are, to my reading, either boring or not relevant but nonetheless LGTM.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109082 run on x86_64-linux 1

2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
8 packages built:
  • charliecloud
  • interlock
  • lxqt.lxqt-sudo
  • mysql-workbench
  • passExtensions.pass-tomb
  • qsudo
  • sudo
  • tomb

@TredwellGit TredwellGit added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
@Ma27 Ma27 merged commit 9e3a6ea into NixOS:master Jan 15, 2021
@Ma27 Ma27 mentioned this pull request Jan 15, 2021
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@Ma27 Ma27 Ma27 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@delroth @lukegb @SuperSandro2000 @Ma27 @TredwellGit