Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: remove unused override #109117

Merged
merged 1 commit into from Jan 12, 2021
Merged

firefox: remove unused override #109117

merged 1 commit into from Jan 12, 2021

Conversation

alyssais
Copy link
Member

Motivation for this change

This isn't used:

$ git grep -w python pkgs/applications/networking/browsers/firefox
$
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
firefox: remove unused override
27a490d 
This isn't used:

    $ git grep -w python pkgs/applications/networking/browsers/firefox
    $
@lukegb
Copy link
Contributor

lukegb commented Jan 12, 2021

@ofborg build firefoxPackages.firefox firefoxPackages.firefox-esr-78

ajs124
ajs124 approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of stuff like this in the firefox derivation(s). I've been meaning to clean it up and switching to compiling with clang, but haven't gotten around to finishing that work.

@alyssais alyssais merged commit a8d2393 into NixOS:master Jan 12, 2021
@alyssais alyssais deleted the firefox branch January 12, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @lukegb @ajs124