Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abuse: init at 0.8 #109064

Merged
merged 1 commit into from Feb 8, 2021
Merged

abuse: init at 0.8 #109064

merged 1 commit into from Feb 8, 2021

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 12, 2021

Motivation for this change

abuse is an old action side-scrolling game available in Arch. This pull request adds it to nixpkgs.

Getting music to play was not entirely trivial, as the timidity bundled by SDL_mixer expects a valid configuration in /etc/timidity.cfg or several other places.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/games/abuse/default.nix Outdated Show resolved Hide resolved
pkgs/games/abuse/abuse.sh Show resolved Hide resolved
pkgs/games/abuse/default.nix Outdated Show resolved Hide resolved
pkgs/games/abuse/default.nix Outdated Show resolved Hide resolved
pkgs/games/abuse/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109064 run on x86_64-linux 1

1 package built:
  • abuse

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109064 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@iblech
Copy link
Contributor Author

iblech commented Jan 12, 2021

I'll mark it as broken on darwin, having no possibility to debug it myself.

pkgs/games/abuse/default.nix Show resolved Hide resolved
pkgs/games/abuse/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109064 run on x86_64-linux 1

1 package built:
  • abuse

@ehmry ehmry merged commit d2e0fb3 into NixOS:master Feb 8, 2021
@iblech
Copy link
Contributor Author

iblech commented Feb 8, 2021

Thank you @ehmry for the merge :-) Have a good day!

@ehmry
Copy link
Contributor

ehmry commented Feb 8, 2021

Thanks for packaging. I'm supprised we didn't have it already, I remember playing this on Gentoo long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants