Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resholve: don't propagate, 0.4.0 -> 0.4.1 #109063

Merged
merged 1 commit into from Jan 17, 2021
Merged

resholve: don't propagate, 0.4.0 -> 0.4.1 #109063

merged 1 commit into from Jan 17, 2021

Conversation

abathur
Copy link
Member

@abathur abathur commented Jan 12, 2021 •
edited

Motivation for this change

While using resholvePackage on a project with a python3.8 component, I noticed resholve's propagated dependencies were leaking into that build environment. There's a little more information about the error and the solution used here (馃槏 @jtojnar) in abathur/resholve#20.

Things done
  • Tested in resholve's CI @ https://github.com/abathur/resholve/actions/runs/479039322
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109063 run on x86_64-linux 1

1 package built:
  • resholve

@abathur
Copy link
Member Author

abathur commented Jan 16, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 16, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from timokau January 17, 2021 04:59
@SuperSandro2000 SuperSandro2000 merged commit 87008c8 into NixOS:master Jan 17, 2021
@abathur abathur removed the request for review from timokau January 17, 2021 15:50
@abathur abathur deleted the fix/resholve-do-not-propagate branch March 4, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abathur @SuperSandro2000