Reenable working clfswm #109066
Reenable working clfswm #109066
Conversation
Replace a tab with spaces to fix a failing EditorConfig check.
| baseName = ''clfswm''; | ||
| version = ''20161204-git''; | ||
|
|
||
| description = ''CLFSWM: Fullscreen Window Manager''; |
There was a problem hiding this comment.
| baseName = ''clfswm''; | |
| version = ''20161204-git''; | |
| description = ''CLFSWM: Fullscreen Window Manager''; | |
| baseName = "clfswm"; | |
| version = "20161204-git"; | |
| description = "CLFSWM: Fullscreen Window Manager"; |
| url = ''http://beta.quicklisp.org/archive/clfswm/2016-12-04/clfswm-20161204-git.tgz''; | ||
| sha256 = ''1jgz127721dgcv3qm1knc335gy04vzh9gl0hshp256rxi82cpp73''; |
There was a problem hiding this comment.
| url = ''http://beta.quicklisp.org/archive/clfswm/2016-12-04/clfswm-20161204-git.tgz''; | |
| sha256 = ''1jgz127721dgcv3qm1knc335gy04vzh9gl0hshp256rxi82cpp73''; | |
| url = "http://beta.quicklisp.org/archive/clfswm/2016-12-04/clfswm-20161204-git.tgz"; | |
| sha256 = "1jgz127721dgcv3qm1knc335gy04vzh9gl0hshp256rxi82cpp73"; |
Can we reuse version here?
|
@SuperSandro2000 Regarding all your comments clfswm.nix: all .nix files in the quicklisp-to-nix-output directory are automatically generated by quicklisp-to-nix (see README.txt in lisp-modules, as well as the "quicklisp-to-nix" derivation in lisp-packages.nix in the same directory). quicklisp-to-nix uses a templating library to produce these .nix files, which uses double single-quoted strings. I'm not familiar enough with this implementation to know if there's a fundamental reason for this, or if the original author just happened to think this was a better idea, but I can say the template file has used these double single-quoted strings since this was originally implemented in March 2017. If this is a problem, we should update quicklisp-to-nix and regenerate all packages in quicklisp-to-nix-output, which seems like it should be its own issue. Perhaps the original author (@7c6f434c) should weigh in? |
|
Didn't know that. You are right that it should be changed in the generator. |
|
I am not even the original author of the generating scripts… |
Sorry; based on Cheers for the merge! |
|
@7c6f434c
> I am not even the original author of the generating scripts…
Sorry; based on `git log -- /path/to/nix-package.emb`, it looked like you added this in commit 1300795. At any rate, you have the most commits against files in the quicklisp-to-nix directory, so I figured you would be the best person to weigh in on whether or not there were any blocking issues.
Ah, it does reuse my old template from the earlier generator
I am more or less sure that using " or '' based on presence of " in the upstream descriptions is not worth it, and then it is more escaping vs more abuse of '' in the code that is not supposed to be read, so I am not convinced " is even better here.
|
Motivation for this change
I'm interested in trying out Common Lisp window managers, specifically CLFSWM. It appears that this window manager was never moved over to using quicklisp, as StumpWM (another Common Lisp window manager) was.
Things done
Added CLFSWM through quicklisp.
Added the 'clfswm' nixos module back in.
Updated the 'clfswm' nixos module to use the quicklisp CLFSWM, and not the normal (broken) CLFSWM package.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)