Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python3Packages.paramiko: 2.7.1 -> 2.7.2, python3Packages.sshtunnel: 0.3.1 -> 0.4.0 #109068

Merged
merged 2 commits into from Jan 12, 2021
Merged

[staging] python3Packages.paramiko: 2.7.1 -> 2.7.2, python3Packages.sshtunnel: 0.3.1 -> 0.4.0 #109068

merged 2 commits into from Jan 12, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 12, 2021 •
edited

Motivation for this change

Updating packages I maintain

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner January 12, 2021 01:57
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build azure-cli

@SuperSandro2000
Copy link
Member

If it is only 100 to 500 rebuilds we could also merge it into master.

But building staging takes to long with my machine.

@jonringer jonringer merged commit 93794d7 into NixOS:staging Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SuperSandro2000