Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats: 1.2.0 -> 1.2.1 #109069

Merged
merged 1 commit into from Jan 18, 2021
Merged

bats: 1.2.0 -> 1.2.1 #109069

merged 1 commit into from Jan 18, 2021

Conversation

abathur
Copy link
Member

@abathur abathur commented Jan 12, 2021

Motivation for this change

Update bats for new setup/teardown_file fixtures :)

See inline notes for the two patchPhase items removed.

@LnL7 I am hoping you have some private projects that exercise this? It looks like resholve is the only one in nixpkgs that does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@abathur abathur marked this pull request as draft January 12, 2021 02:04
@abathur
Copy link
Member Author

abathur commented Jan 12, 2021

Stepping back to draft to try and get bats own test suite running.

@abathur abathur force-pushed the update/bats-1.2.1 branch 2 times, most recently from e123ba5 to 4a8c801 Compare January 12, 2021 05:23
@abathur abathur marked this pull request as ready for review January 12, 2021 06:17
@abathur abathur marked this pull request as draft January 16, 2021 17:52
@abathur abathur marked this pull request as ready for review January 16, 2021 18:07
@abathur
Copy link
Member Author

abathur commented Jan 16, 2021

Force-pushed to swap myself in as maintainer. LnL confirmed on IRC that he no longer has projects using bats.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109069 run on x86_64-darwin 1

2 packages built:
  • bats
  • resholve

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109069 run on x86_64-linux 1

2 packages built:
  • bats
  • resholve

@SuperSandro2000 SuperSandro2000 merged commit 2a28c3a into NixOS:master Jan 18, 2021
@abathur abathur deleted the update/bats-1.2.1 branch March 4, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants