Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mindustry: fix desktop item #109121

Merged
1 commit merged into from Jan 12, 2021
Merged

mindustry: fix desktop item #109121

1 commit merged into from Jan 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2021

  • make pre- and post-{build,install} phases usable for the main derivation
  • replace uses of stdenv.lib with just lib
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from fgaz January 12, 2021 16:11
mindustry: fix desktop item
70b9f1c 
- make pre- and post-{build,install} phases usable for the main derivation
- replace uses of stdenv.lib with just lib
- specify which buildInputs are only needed for the client
@fgaz
Copy link
Member

fgaz commented Jan 12, 2021

@GrahamcOfBorg build mindustry,mindustry-server

@fgaz
Copy link
Member

fgaz commented Jan 12, 2021

oops, wrong syntax

@GrahamcOfBorg build mindustry mindustry-server

@ofborg ofborg bot requested a review from fgaz January 12, 2021 18:26
@ghost ghost merged commit 213286b into NixOS:master Jan 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgaz fgaz Awaiting requested review from fgaz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fgaz