Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT updates for highlight painting order (css-pseudo) #27147

Merged
merged 1 commit into from Jan 14, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 12, 2021

This patch updates four web platform tests involving CSS highlight
painting order, which should help us rework our highlight paint code
to comply with css-pseudo.

• css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html
• two manual tests, checking the relative painting order of
::selection and ::{grammar,spelling}-error overlays
• added @contenteditable/@spellcheck/@lang to test element
• added Selection#removeAllRanges call to work around API change
• replaced the grammar test sentence with a more obvious example
• rewrote most of the comments for clarity

• css/css-pseudo/highlight-painting-order.html
• new reftest, checking relative painting order of text, original
shadows, ::selection background, and ::selection shadows
• based on <https://bucket.daz.cat/work/igalia/0/3.html>

• css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html
• one manual test, one reftest, checking that text-shadow:none in
::selection suppresses all original shadows (even if multiple)
• dropped because they are no longer compliant (highlight overlays
have their own shadows, independent of the content’s shadows)

Bug: 1147859
Change-Id: I29bab589e3924778d555d96537d010dc33ed003f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843482}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2624328 branch 2 times, most recently from aba51be to ba86ed5 Compare January 14, 2021 10:41
This patch updates four web platform tests involving CSS highlight
painting order, which should help us rework our highlight paint code
to comply with css-pseudo.

• css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html
    • two manual tests, checking the relative painting order of
      ::selection and ::{grammar,spelling}-error overlays
    • added @contenteditable/@spellcheck/@lang to test element
    • added Selection#removeAllRanges call to work around API change
    • replaced the grammar test sentence with a more obvious example
    • rewrote most of the comments for clarity

• css/css-pseudo/highlight-painting-order.html
    • new reftest, checking relative painting order of text, original
      shadows, ::selection background, and ::selection shadows
    • based on <https://bucket.daz.cat/work/igalia/0/3.html>

• css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html
    • one manual test, one reftest, checking that text-shadow:none in
      ::selection suppresses all original shadows (even if multiple)
    • dropped because they are no longer compliant (highlight overlays
      have their own shadows, independent of the content’s shadows)

Bug: 1147859
Change-Id: I29bab589e3924778d555d96537d010dc33ed003f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843482}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants