[FSA] Allow seeking past the end of a file #27146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 12, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2593810
branch
2 times, most recently
from
0fd93a1
to
44d97eb
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2593810
branch
2 times, most recently
from
41a7ca3
to
c3e5db3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2593810
branch
from
c3e5db3
to
1ecea9e
Compare
Currently, we reject all attempts to write past the end of a file. This change makes the API more consistent with the behavior of POSIX. If writing at an offset past the end of a file, the null bytes between the old end of the file and the offset will count towards the file's quota. Adds Quota tests to the SandboxFSW. Bug: 1153385 Change-Id: Iec54acbccecb728f9375931825525ba2fbafd1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593810 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#850838}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2593810
branch
from
1ecea9e
to
4c67dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we reject all attempts to write past the end of a file. This
change makes the API more consistent with the behavior of POSIX.
If writing at an offset past the end of a file, the null bytes between
the old end of the file and the offset will count towards the file's
quota.
Adds Quota tests to the SandboxFSW.
Bug: 1153385
Change-Id: Iec54acbccecb728f9375931825525ba2fbafd1ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593810
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850838}