Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gem-config: make nokogiri use pkg-config #109076

Closed
wants to merge 1 commit into from
Closed

gem-config: make nokogiri use pkg-config #109076

wants to merge 1 commit into from

Conversation

thatsmydoing
Copy link
Contributor

Motivation for this change

nokogiri 1.11.x is broken with current nixpkgs. This can be reproduced with:

nix-build --option sandbox true --expr '(import ./. {}).rubyPackages_2_7.nokogiri.override { version = "1.11.1"; source.sha256 = "1ajwkqr28hwqbyl1l3czx4a34c88acxywyqp8cjyy0zgsd6sbhj2"; }'

The error is that zlib can't be found.

Things done

This can be fixed by specifying the lib and include directories separately but I also took the opportunity to just make it use pkg-config instead. I'm not sure what the original reasons for not using it were, possibly it just didn't use pkg-config at the time. I've tested the build with the current version of nokogiri in nixpkgs and it builds fine as well.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thatsmydoing
Copy link
Contributor Author

thatsmydoing commented Jan 12, 2021 •
edited

I hadn't searched properly and found that the problem this is solving was already fixed in #108831 but maybe there's still value in using pkgconfig here instead of keeping the explicit build flags.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 12, 2021 •
edited

That was actually suggested in #108924.

CLosing because the dependencies shouldn't change again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thatsmydoing @SuperSandro2000