go: Introduce environment variable GO_NO_VENDOR_CHECKS to relax go vendor checks #109127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndor checks This is used in https://github.com/tweag/gomod2nix to reconstruct a vendor metadata file. With the vendor checks we need a lot more metadata which isn't relevant for building packages, especially since we've already locked the dependency graph ahead of time This has been ported from FreeBSD: https://reviews.freebsd.org/D24122
|
Should be fine. I was wondering though, how hard it would be to generate modules.txt manually? |
ofborg
bot
requested review from
cstrahan,
c00w,
Frostman,
rvolosatovs and
mdlayher
|
@Mic92 The general structure is trivially generated, the problem is that modules.txt requires a lot of extra data we don't have inside the sandbox like where replace directives are pointing to and such, and some of these potentially require networking to figure out. |
rvolosatovs
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used in https://github.com/tweag/gomod2nix to reconstruct a
vendor metadata file.
With the vendor checks we need a lot more metadata which isn't
relevant for building packages, especially since we've already locked
the dependency graph ahead of time
This patch has been ported from FreeBSD: https://reviews.freebsd.org/D24122.
See golang/go#37948 for discussion.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Acknowledgements
This work is done within the context of Trustix and has been sponsored by a NLNet Foundation NGI-0 PET grant.