Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about DOMException constructor behavior testing #27151

Closed
kt3k opened this issue Jan 12, 2021 · 3 comments · Fixed by #27181
Closed

Question about DOMException constructor behavior testing #27151

kt3k opened this issue Jan 12, 2021 · 3 comments · Fixed by #27181
Labels
webidl

Comments

@kt3k
Copy link
Contributor

kt3k commented Jan 12, 2021

In the test of the error name table of DOMException in this file, the error codes 2, 6, 16, 17 are omitted. Is this intended?

In the WebIDL, the error codes 1, 2, 6, 15, 16, and 17 are marked "Deprecated". https://heycam.github.io/webidl/#idl-DOMException-error-names

If the above 4 codes are intentionally omitted because of the deprecation, then should we keep testing about the error code 1 and 15?
@stephenmcgruer
Copy link
Contributor

cc @domenic

@domenic
Copy link
Member

domenic commented Jan 13, 2021

We should test all of them. "Deprecated" means "don't use in future specs", but it's still part of the web platform and should still be tested.

@kt3k
Copy link
Contributor Author

kt3k commented Jan 14, 2021

@domenic Thank you for your advice! So it seems that the current test cases are incomplete on testing these (deprecated) error code mappings. I'll send a PR for it.

@kt3k kt3k mentioned this issue Jan 14, 2021
Merged
domenic pushed a commit that referenced this issue Jan 15, 2021
@kt3k
DOMException: test code mapping for all error names
93c6fac 
In particular, this tests the deprecated ones, some removed ones, and some newer error names which intentionally don't have legacy error codes. See also whatwg/webidl#946.

Closes #27151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
webidl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOMException] add test cases of error names table kt3k/wpt
3 participants
@stephenmcgruer @kt3k @domenic