Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matcha-gtk-theme: 2020-12-07 -> 2021-01-12 #109129

Merged
merged 1 commit into from Jan 12, 2021
Merged

matcha-gtk-theme: 2020-12-07 -> 2021-01-12 #109129

merged 1 commit into from Jan 12, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 12, 2021

Motivation for this change

Update to version 2021-01-12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hugolgst
Copy link
Member

Result of nixpkgs-review pr 109129 1

1 package built:
  • matcha-gtk-theme

hugolgst
hugolgst approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109129 run on x86_64-linux 1

1 package built:
  • matcha-gtk-theme

@SuperSandro2000 SuperSandro2000 merged commit f4f5e32 into NixOS:master Jan 12, 2021
@romildo romildo deleted the upd.matcha-gtk-theme branch January 12, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @hugolgst @SuperSandro2000