Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plane sprite and shadow get reversed when terrain under hangar tile of airport is lowered #8560

Closed
Andrew350 opened this issue Jan 12, 2021 · 5 comments
Closed

Plane sprite and shadow get reversed when terrain under hangar tile of airport is lowered #8560

Andrew350 opened this issue Jan 12, 2021 · 5 comments

Comments

@Andrew350
Copy link

Andrew350 commented Jan 12, 2021 •
edited

Version of OpenTTD

20210111-master

Expected result

Planes are drawn normally

Actual result

When a plane lands at an airport where the tile under the hangar is lowered (see screenshot), the plane sprites and their shadows appear to get swapped around, causing them to clip into the terrain and buildings. This affects all airports.

Steps to reproduce

Build airport
Lower terrain under hangar
Land plane at airport

Screenshot showing the issue:

plane-bug

And a small savegame with an airport and plane already built showing the issue:

plane-bug-save.zip
@Andrew350 Andrew350 changed the title Plane sprite and shadow get reversed when terrain under north tile of airport is lowered Plane sprite and shadow get reversed when terrain under hangar tile of airport is lowered Jan 12, 2021
@erenes
Copy link

erenes commented Jan 13, 2021

I could not reproduce this in 1.10.2, but when loading the savegame I made (in 1.10.2) using the latest nightly (20210112) it reproduced immediately, so definitely a regression.

@James103
Copy link
Contributor

@erenes Have you tried reproducing this in 1.10.3?

@erenes
Copy link

erenes commented Jan 13, 2021

I did now, it also does not reproduce on 1.10.3 for me.

@James103
Copy link
Contributor

Are you able to git bisect through the nightlies from release 1.10.3 through present? If so, which commit introduced the bug?

@LordAro
Copy link
Member

LordAro commented Jan 13, 2021

This will be a result of #8458 . Made assumptions about the hangar being on flat land, which obviously isn't the case. Should be a relatively easy fix.

LordAro added a commit to LordAro/OpenTTD that referenced this issue Jan 13, 2021
@LordAro
Fix OpenTTD#8560: Planes were landing at the wrong height at airports…
520ab81 
… with lowered hangar tiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erenes @LordAro @James103 @Andrew350