New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhall-json, dhall-lsp-server, dhall-yaml: unmark as broken #109126
dhall-json, dhall-lsp-server, dhall-yaml: unmark as broken #109126
Conversation
@@ -73198,7 +73198,6 @@ self: { | |||
description = "Convert between Dhall and JSON or YAML"; | |||
license = stdenv.lib.licenses.bsd3; | |||
hydraPlatforms = stdenv.lib.platforms.none; | |||
broken = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcwitt Thanks for making the effort to fix this.
Unfortunately this file hackage-packages.nix
is regenerated automatically once a day based on the configuration-hackage2nix.yaml
file. You'll have to remove these three packages from the broken-packages
section in that file.
Once you do this, I can merge this PR in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I had been confused about which files were auto-generated from Hackage. This makes sense, changed.
A lot of people that contribute to Nixpkgs don't have access to a MacOSX machine to test on, so a lot of changes are made without even seeing how they affect OSX. If However, I don't think Also, if you've tried building it on OSX, maybe you could post the build log with the error you're seeing? If it is not something nixpkgs specific, it may make sense to report it upstream. |
68fe107
to
54c3a3b
Compare
That makes sense, thanks. The situation with
but when I reran just now it succeeded 🤷 . Maybe best to disable tests when we hit nondetermistic behavior. In any case, considering your advice above, seems like the right thing to leave this for a future PR. |
@mcwitt When trying to build these packages locally, I am seeing the same failure with I'd suggest first reporting this upstream on the Then, either disable the tests for Also, feel free to just drop |
54c3a3b
to
48db582
Compare
@cdepillabout sounds good, thanks! I've dropped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that sounds good!
This should be marked as non-broken the next time the automated script runs on the |
Motivation for this change
Several dhall-related packages are marked as broken, but appear to be building correctly (tested on NixOS).
Update:
dhall-yaml
fails to build on macOS; does this mean it should still be "broken" (even though it builds on NixOS)?Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)