Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve terminology #27152

Merged
merged 1 commit into from Jan 20, 2021
Merged

Conversation

mhdawson
Copy link
Contributor

Related to the effort in the Node.js project to rename
the primary branch to main we are also looking to
remove other references to related terminology.

One instance is through the copy of this file that
we have from wpt as part of the Node.js tests:
https://github.com/nodejs/node/blob/master/test/fixtures/wpt/common/security-features/README.md

Generally we want changes in dependencies landed
upstream first before updating in the Node.js repo
which is why I'm submitting the PR to change it
here first, to be followed by updating wpt in
Node.js core to pull in the change.

Signed-off-by: Michael Dawson mdawson@devrus.com

Related to the effort in the Node.js project to rename
the primary branch to main we are also looking to
remove other references to related terminology.

One instance is through the copy of this file that
we have from wpt as part of the Node.js tests:
https://github.com/nodejs/node/blob/master/test/fixtures/wpt/common/security-features/README.md

Generally we want changes in dependencies landed
upstream first before updating in the Node.js repo
which is why I'm submitting the PR to change it
here first, to be followed by updating wpt in
Node.js core to pull in the change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@Ms2ger Ms2ger merged commit 841a514 into web-platform-tests:master Jan 20, 2021
mhdawson added a commit to mhdawson/io.js that referenced this pull request Jan 21, 2021
Update common section in wpt to incorporate
improved terminology fixed upstream in
web-platform-tests/wpt#27152

Signed-off-by: Michael Dawson <mdawson@devrus.com>
Trott pushed a commit to mhdawson/io.js that referenced this pull request Jan 27, 2021
Update common section in wpt to incorporate
improved terminology fixed upstream in
web-platform-tests/wpt#27152

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#37011
Reviewed-By: Milad Fa <mfarazma@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Feb 2, 2021
Update common section in wpt to incorporate
improved terminology fixed upstream in
web-platform-tests/wpt#27152

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #37011
Reviewed-By: Milad Fa <mfarazma@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants