Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: fix darwin builds #109137

Closed
wants to merge 2 commits into from
Closed

crystal: fix darwin builds #109137

wants to merge 2 commits into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Jan 12, 2021 •
edited

Motivation for this change

Darwin builds for Crystal are currently failing because of a test not passing anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

cc @SuperSandro2000 can you build crystal_0_32 on darwin, may take a while

@jonringer jonringer added the 6.topic: darwin Running or building packages on Darwin label Jan 12, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 13, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109137 run on x86_64-darwin 1

17 packages failed to build and are new build failures:
  • ameba: log was empty
  • crystal: log was empty
  • (crystal_0_35): log was empty
  • crystal2nix: log was empty
  • crystal_0_31: log https://termbin.com/d8y5
  • crystal_0_32: log was empty
  • crystal_0_33: log was empty
  • crystal_0_34: log was empty
  • gitAndTools.thicket: log was empty
  • icr: log was empty
  • lucky-cli: log was empty
  • mint: log was empty
  • oq: log was empty
  • scry: log was empty
  • shards: log was empty
  • (shards_0_12): log was empty
  • shards_0_11: log was empty
CRYSTAL_CONFIG_PATH="/private/tmp/nix-build-crystal-0.31.1.drv-0/source/src" CRYSTAL_CONFIG_LIBRARY_PATH="" CRYSTAL_CONFIG_BUILD_COMMIT="" ./bin/crystal build --release --single-module  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
./bin/crystal: /nix/store/zs5zg9b93z23270jv0l1j4qczjj0gddq-crystal-binary-0.31.1/bin/crystal: /usr/bin/env: bad interpreter: Operation not permitted
./bin/crystal: line 154: /nix/store/zs5zg9b93z23270jv0l1j4qczjj0gddq-crystal-binary-0.31.1/bin/crystal: Undefined error: 0
make: *** [Makefile:132: .build/crystal] Error 1

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109137 run on x86_64-linux 1

17 packages failed to build and are new build failures:
  • ameba: log was empty
  • crystal: log was empty
  • (crystal_0_35): log was empty
  • crystal2nix: log was empty
  • crystal_0_31: log https://termbin.com/sn0f7
  • crystal_0_32: log was empty
  • crystal_0_33: log was empty
  • crystal_0_34: log was empty
  • gitAndTools.thicket: log was empty
  • icr: log was empty
  • lucky-cli: log was empty
  • mint: log was empty
  • oq: log was empty
  • scry: log was empty
  • shards: log was empty
  • (shards_0_12): log was empty
  • shards_0_11: log was empty

@ofborg ofborg bot requested a review from fabianhjr January 13, 2021 18:45
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109137 run on x86_64-darwin 1

17 packages failed to build and are new build failures:
  • ameba: log was empty
  • crystal: log was empty
  • (crystal_0_35): log was empty
  • crystal2nix: log was empty
  • crystal_0_31: log https://termbin.com/hw3d
  • crystal_0_32: log was empty
  • crystal_0_33: log was empty
  • crystal_0_34: log was empty
  • gitAndTools.thicket: log was empty
  • icr: log was empty
  • lucky-cli: log was empty
  • mint: log was empty
  • oq: log was empty
  • scry: log was empty
  • shards: log was empty
  • (shards_0_12): log was empty
  • shards_0_11: log was empty

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109137 run on x86_64-darwin 1

16 packages failed to build and are new build failures:
  • ameba: log was empty
  • crystal: log was empty
  • (crystal_0_35): log was empty
  • crystal2nix: log was empty
  • crystal_0_32: log https://termbin.com/yb6ay
  • crystal_0_33: log was empty
  • crystal_0_34: log was empty
  • icr: log was empty
  • lucky-cli: log was empty
  • mint: log was empty
  • oq: log was empty
  • scry: log https://termbin.com/9myu
  • shards: log was empty
  • (shards_0_12): log was empty
  • shards_0_11: log was empty
  • thicket: log was empty
1 package built:
  • crystal_0_31

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109137 run on x86_64-linux 1

4 packages failed to build and are new build failures:
11 packages built:
  • ameba
  • crystal (crystal_0_35)
  • crystal2nix
  • crystal_0_31
  • crystal_0_32
  • crystal_0_33
  • crystal_0_34
  • lucky-cli
  • shards (shards_0_12)
  • shards_0_11
  • thicket

@manveru
Copy link
Contributor Author

manveru commented Jan 15, 2021

These packages need to be fixed independently. I don't think there's anything new about their failure...

@SuperSandro2000
Copy link
Member

The following still does not build for darwin:

crystal_0_35: log was empty
crystal_0_32: log termbin.com/yb6ay
crystal_0_33: log was empty
crystal_0_34: log was empty

@siraben
Copy link
Member

siraben commented Jul 1, 2021 •
edited

@manveru please fix the merge conflict.

@Artturin
Copy link
Member

#131808

@Artturin Artturin closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@jonringer jonringer jonringer approved these changes

@david50407 david50407 Awaiting requested review from david50407

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@fabianhjr fabianhjr Awaiting requested review from fabianhjr

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@manveru @SuperSandro2000 @siraben @Artturin @fabianhjr @disassembler @jonringer