Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searx: 0.17.0 -> 0.18.0 #109114

Merged
merged 3 commits into from Jan 14, 2021
Merged

searx: 0.17.0 -> 0.18.0 #109114

merged 3 commits into from Jan 14, 2021

Conversation

illustris
Copy link
Contributor

@illustris illustris commented Jan 12, 2021

Motivation for this change

Searx 0.17 doesn't seem to work any more. Queries don't return results.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/servers/web-apps/searx/default.nix Outdated Show resolved Hide resolved
pkgs/servers/web-apps/searx/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109114 run on x86_64-linux 1

1 package built:
  • searx

@illustris
Copy link
Contributor Author

Requested changes made.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 12, 2021

This update broke the uWSGI support in the NixOS module.
I see a ValueError: Empty module name, but nothing else. I'm currently bisecting.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 12, 2021

Found it:

116f7a6daaa2d29db30bc0765427d011fa99ce9c is the first bad commit
commit 116f7a6daaa2d29db30bc0765427d011fa99ce9c
Author: Noémi Ványi <sitbackandwait@gmail.com>
Date:   Fri Oct 9 15:49:48 2020 +0200

    Force admins to set secret_key if debug mode is disabled
    
    This commit also enables debug mode for unit tests.

Looks like we must set secret_key in the test.

@SuperSandro2000
Copy link
Member

@rnhmjoj maybe we could add you as a maintainer so that you get auto notified of updates. Should be a different PR probably.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 13, 2021

@SuperSandro2000 yes, I'm pretty involved in searx at this point, it would make sense.

@illustris, thank you! Everything looks good, can you just squash the fix commits into the first one? You can use git rebase -i HEAD~5,

@illustris
Copy link
Contributor Author

@rnhmjoj I just notices that I squashed your two commits commits to nixos/modules/services/networking/searx.nix and nixos/tests/searx.nix. I've rebased to include just the three commits to pkgs/servers/web-apps/searx/default.nix. Please add the service and test changes again.

Starting with 0.18.0, searx can merge the settings.yml automatically
with the default values, so the script is obsolete.
@rnhmjoj rnhmjoj merged commit 721a4ec into NixOS:master Jan 14, 2021
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 14, 2021

@illustris Done, and thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants