dune: let dune 1 install itself #109143
Merged
dune: let dune 1 install itself #109143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
force-pushed
the
dune-install-itself
branch
2 times, most recently
from
5ccd3f4
to
36d88a6
Compare
hugolgst
reviewed
Jan 12, 2021
|
Build errors:
Result of 6 packages failed to build:
532 packages built:
|
Reference NixOS#108938.
sternenseemann
force-pushed
the
dune-install-itself
branch
from
36d88a6
to
d711743
Compare
10 tasks
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Jan 28, 2021
Since <NixOS#109143> has been merged, switching opam-file-format doesn't create a cyclical dependency of opam-file-format -> dune -> opaline -> opam-file-format anymore. Thus we switch to dune which seems to be supported better by upstream and doesn't require us to patch the 2.1.2 release.
vbgl
pushed a commit
that referenced
this pull request
Jan 28, 2021
Since <#109143> has been merged, switching opam-file-format doesn't create a cyclical dependency of opam-file-format -> dune -> opaline -> opam-file-format anymore. Thus we switch to dune which seems to be supported better by upstream and doesn't require us to patch the 2.1.2 release.
aforemny
pushed a commit
to aforemny/nixpkgs
that referenced
this pull request
Mar 4, 2021
Since <NixOS#109143> has been merged, switching opam-file-format doesn't create a cyclical dependency of opam-file-format -> dune -> opaline -> opam-file-format anymore. Thus we switch to dune which seems to be supported better by upstream and doesn't require us to patch the 2.1.2 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This removes the dependency on
opalineand means we could useduneforopam-file-formatand the likes.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)