Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nextcloud: document adminpassFile permissions #109144

Merged
merged 1 commit into from Feb 5, 2021

Conversation

sephalon
Copy link
Contributor

Motivation for this change

The required permissions are non-obvious without having a look at the implementation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Jan 12, 2021

Instead of this documentation change we might consider fixing the problem instead via LoadCredential.

@aanderse
Copy link
Member

Is anyone interested in looking into LoadCredential?

@sephalon
Copy link
Contributor Author

LoadCredential sounds good to me. I'll have a look into that.

@Ma27
Copy link
Member

Ma27 commented Feb 5, 2021

I think that's fine. Rather than waiting for a perfect fix, documenting this is fine for now so that people are warned.

@Ma27 Ma27 merged commit 778238c into NixOS:master Feb 5, 2021
@Ma27
Copy link
Member

Ma27 commented Feb 5, 2021

Ported to stable as 7f1d27f.

@sephalon sephalon deleted the nextcloud-service-doc branch September 13, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants