-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all sounds derived from non-free sources #8
Conversation
48d937f
to
51f10be
Compare
My thoughts, things where there was a difference I thought worth noting:
|
51f10be
to
28b007a
Compare
Note I have force-pushed a couple of times and updated various sounds, so please check again.
I also strong recommend to actually test the sounds in-game. OpenTTD seems to alter the volume of some of the sounds, and this can have a big impact. |
28b007a
to
54e8c35
Compare
Updated: osfx_61, osfx_54 |
Ah yes, that makes a lot more sense as a Toyland sound. I wonder if there's a way to get a "clean" version without the extraneous sounds. (Are they different enough in tone that a spectral repair would work?) The echo improves 5 a lot. The difficulty sometimes with sounds is even with a real source, noise reduction and repair can remove enough to make things sound like a pure tone. OpenTTD can tolerate noisier samples because it's not doing too much with them; they're mostly just ambient sounds and not processed further into a mix where very clean originals are desirable. |
54e8c35
to
d60066a
Compare
Updated toy factory sounds |
d60066a
to
285f26f
Compare
I just replaced the railroad crossing sound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I haven't reproduced every sound in-game, I have listed to all the modified sounds and checked over the readme/.sfo changes you've made and I'd say they look (sound) good to me.
You may wish to add yourself to the "Sound editors" section though, @Wuzzy2, since you have edited various sounds now.
I would also ask that you re-title your commits in the standard OpenTTD way - e.g., "Change: Replace all sounds...", and so on.
285f26f
to
faed80c
Compare
Okay, I added myself to the credits and change the commit names. Anything else? |
faed80c
to
37a1776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort in helping to sort this!
This PR does two things:
Details
I have tried to make the new sounds more or less "close enough" to the previous version, whenever it made sense. An important rule I followed is to roughly keep the length of the old sound.
Sounds that were derived from clear free sources (CC0, CC BY, CC BY-SA) are not touched, with one exception:
osfx_26.wav
("Bus start, pull away with horn").You will notice that
osfx_25.wav
("Bus start, pull away") sounds almost identical to the previous version. But it's actually not the same file. I simply used the source filefile0375.mp3
(which is CC0'ed) and made my own editing, in order to get rid of Sampling Plus. I did this so I could then remakeosfx_26.wav
, which is the same sound, but with a horn.osfx_26.wav
includes a new horn sound.WIP
I am almost happy with the new sounds, but it might not be perfect. What still needs to be done is in-game testing. I might still change a few sounds a little if I discover problems.
PLEASE do review all the new sounds yourself and enjoy! :)
See the text file updates in this PR to see which sounds are new.
Phase 1
Note that this PR intentionally does not replace ALL sounds. Consider this PR to be "phase 1" of the "liberation" process. :D With this PR, many sounds are still CC Sampling Plus'ed (i.e. non-free).
For all sounds that are not be touched by this PR, those sounds were derived from free/libre sources or were created by OpenTTD contributors directly. I want to deal with these sounds in "Phase 2" (which might be a later PR). The only thing that prevents those sounds from being libre is the permission of the sound editors, i.e. the people who downloaded the original sounds from freesound.org, did a little editing for OpenSFX and contributed them. The ideal way to deal with those sounds is to gain permission from those sound editors to change the license (see #6). But if we won't get this permission, the sounds need to be re-done in order to get rid of the nasty Sampling Plus license.