Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.mikestead.dotenv: Init at 1.0.1 #109947

Merged
merged 1 commit into from Jan 22, 2021
Merged

vscode-extensions.mikestead.dotenv: Init at 1.0.1 #109947

merged 1 commit into from Jan 22, 2021

Conversation

andyrichardson
Copy link
Contributor

@andyrichardson andyrichardson commented Jan 19, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andyrichardson
Copy link
Contributor Author

@SuperSandro2000 no pressure/rush!

Wanted to ping you as these changes are based off of your suggestions in previous PRs 🙏

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 22, 2021 •
edited

@SuperSandro2000 no pressure/rush!

Wanted to ping you as these changes are based off of your suggestions in previous PRs 🙏

If a PR slips through feel free to ping me as long as you don't do it on an hourly basis I have no problem with that.

@SuperSandro2000
Copy link
Member

@ofborg eval

@andyrichardson
Copy link
Contributor Author

If a PR slips through feel free to ping me as long as you don't do it on an hourly basis I have no problem with that

Really appreciate it - you rock 🙏

@SuperSandro2000 SuperSandro2000 merged commit 0f11e27 into NixOS:master Jan 22, 2021
@andyrichardson andyrichardson deleted the patch-7 branch February 15, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyrichardson @SuperSandro2000