Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iCE40-feather #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add iCE40-feather #137

wants to merge 1 commit into from

Conversation

shenki
Copy link

@shenki shenki commented Jan 19, 2021

An iCE40UP5K FPGA in a Feather compatible form factor.

https://github.com/joshajohnson/iCE40-feather

@shenki
Copy link
Author

shenki commented Jan 19, 2021

@whatnick @joshajohnson fyi

@joshajohnson
Copy link

I've connected the QSPI pins for the flash on 0.2, is this something that should be added to the pin defs?

image

@whatnick
Copy link

I think we will have to get a v0.2 board to Joel to make this a real thing. Possibly have both v0.1 or v0.2 board definitions. Given v0.1 boards are so few, the main definition can be the v0.2 one.

@shenki
Copy link
Author

shenki commented Jan 19, 2021

Agreed, once we have some v0.2 boards we can decide how to support them. I wanted to submit this definition so we didn't have people duplicating the work of describing the pin layouts.

An iCE40UP5K FPGA in a Feather compatible form factor.

https://github.com/joshajohnson/iCE40-feather

*LEDResources(pins="47", invert=True, attrs=Attrs(IO_STANDARD="SB_LVCMOS")),
# Semantic aliases
Resource("led_r", 0, PinsN("47", dir="o"), Attrs(IO_STANDARD="SB_LVCMOS")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with the LEDs here? If there's one RGB LED then there should be just an RGB LED resource.

Resource("button_sw1", 0, Pins("9", dir="i", conn=("wing", 0)), Attrs(IO_TYPE="LVCMOS33")),
Resource("button_sw2", 0, Pins("10", dir="i", conn=("wing", 0)), Attrs(IO_TYPE="LVCMOS33")),
Resource("button_sw3", 0, Pins("12", dir="i", conn=("wing", 0)), Attrs(IO_TYPE="LVCMOS33")),
Resource("button_sw4", 0, Pins("11", dir="i", conn=("wing", 0)), Attrs(IO_TYPE="LVCMOS33")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Semantic alias" generally means that there is some semantics beyond the numeric index, e.g. button_up would be one.

]
led_wing = [
# Buttons present on the "led wing" attachment
*ButtonResources(pins={0: "9", 1: "10", 2: "12", 3: "11"}, invert=True, attrs=Attrs(IO_STANDARD="SB_LVCMOS")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resource is missing the connector specification.

@shenki
Copy link
Author

shenki commented Feb 3, 2021

Thanks for the review @whitequark. I have learnt a bit more about nmigen and fixed a bunch of things; I'll rework the patch and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants