Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clips: 6.30 -> 6.31 #109914

Closed
wants to merge 1 commit into from
Closed

clips: 6.30 -> 6.31 #109914

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/clips/versions.

meta.description for clips is: "A Tool for Building Expert Systems"

meta.homepage for clips is: "http://www.clipsrules.net/"

meta.changelog for clips is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
clips
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/fn4lkx7nyqxprqwvd2cx7cbl81nwrs48-clips-6.31 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A clips https://github.com/r-ryantm/nixpkgs/archive/12594113909d610bdb6189349904d53498974650.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fn4lkx7nyqxprqwvd2cx7cbl81nwrs48-clips-6.31
ls -la /nix/store/fn4lkx7nyqxprqwvd2cx7cbl81nwrs48-clips-6.31/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • clips

Maintainer pings

cc @league for testing.

pname = "clips";
src = fetchurl {
url = "mirror://sourceforge/clipsrules/CLIPS/6.30/clips_core_source_630.tar.Z";
sha256 = "1r0m59l3mk9cwzq3nmyr5qxrlkzp3njls4hfv8ml85dmqh7n3ysy";
url = "mirror://sourceforge/clipsrules/CLIPS/6.31/clips_core_source_630.tar.Z";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "mirror://sourceforge/clipsrules/CLIPS/6.31/clips_core_source_630.tar.Z";
url = "mirror://sourceforge/clipsrules/CLIPS/6.31/clips_core_source_631.tar.Z";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to derive that fragment from the version to support auto update.

@SuperSandro2000 SuperSandro2000 added the 9.needs: human intervention There were changes that bots cannot deal with. label Jan 19, 2021
@league
Copy link
Contributor

league commented Jan 20, 2021

I started to look into this, but after fixing the URL and hash, it doesn't compile – I guess because they moved things around. Don't have time to look further right now but I can investigate in a day or two.

nix-repl> :b pkgs.callPackage ./default.nix {}
builder for '/nix/store/h542vjk59csmcmpji4q0j61dq5iwdrhg-clips-6.31.drv' failed with exit code 2; last 10 log lines:
  source root is clips_core_source_631
  setting SOURCE_DATE_EPOCH to timestamp 1562107028 of file clips_core_source_631/readme.txt
  patching sources
  configuring
  no configure script, doing nothing
  building
  make: Entering directory '/build/clips_core_source_631/core'
  make: ../makefiles/makefile.gcc: No such file or directory
  make: *** No rule to make target '../makefiles/makefile.gcc'.  Stop.
  make: Leaving directory '/build/clips_core_source_631/core'
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/h542vjk59csmcmpji4q0j61dq5iwdrhg-clips-6.31.drv' failed

Copy link
Contributor

@league league left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got clips-6.31 to build and run, but it doesn't seem like I can push to this PR, or to the auto-update/clips branch. Here's the replacement file. It also derives the URL from the version number.

{ stdenv, fetchurl }:

stdenv.mkDerivation rec {
  version = "6.31";
  pname = "clips";
  src = let v = builtins.replaceStrings [ "." ] [ "" ] version;
  in fetchurl {
    url =
      "mirror://sourceforge/clipsrules/CLIPS/${version}/clips_core_source_${v}.tar.gz";
    sha256 = "165k0z7dsv04q432sanmw0jxmxwf56cnhsdfw5ffjqxd3lzkjnv6";
  };
  buildPhase = ''
    make -C core
  '';
  installPhase = ''
    install -D -t $out/bin core/clips
  '';
  meta = with stdenv.lib; {
    description = "A Tool for Building Expert Systems";
    homepage = "http://www.clipsrules.net/";
    longDescription = ''
      Developed at NASA's Johnson Space Center from 1985 to 1996,
      CLIPS is a rule-based programming language useful for creating
      expert systems and other programs where a heuristic solution is
      easier to implement and maintain than an algorithmic solution.
    '';
    license = licenses.publicDomain;
    maintainers = [maintainers.league];
    platforms = platforms.linux;
  };
}

@SuperSandro2000
Copy link
Member

I got clips-6.31 to build and run, but it doesn't seem like I can push to this PR,

I will push it after doing a little clean up.

@SuperSandro2000 SuperSandro2000 force-pushed the auto-update/clips branch 2 times, most recently from 4a5eca5 to f0c2229 Compare January 25, 2021 23:36
@SuperSandro2000
Copy link
Member

@league it would be great if you could take another look.

@ofborg ofborg bot requested a review from league January 25, 2021 23:51
league added a commit to league/nixpkgs that referenced this pull request Feb 23, 2021
@r-ryantm r-ryantm deleted the auto-update/clips branch February 25, 2021 00:27
SuperSandro2000 added a commit that referenced this pull request Feb 26, 2021
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants